Re: [Ext2-devel] [PATCH 1/9] extents for ext4

Randy.Dunlap
2006-08-10T17:47:15Z

On Thu, 10 Aug 2006 13:29:56 +0400 Alex Tomas wrote:

> >>>>> Andrew Morton (AM) writes:
>
> >> From a quick scan:
>
> AM> - The code is very poorly commented. I'd want to spend a lot of time
> AM> reviewing this implementation, but not in its present state.
>
> what sort of comments are you expecting?

Helpful ones. Not obvious stuff. Intents.
Tricks used (if they are the right thing to do).

How, what, why. But not nitty-gritty details of how.
"Why" is often more important.

> AM> - The existing comments could benefit from some rework by a native English
> AM> speaker.
>
> could someone assist here, please?

Yes. How would you like it? Just comments via email or (quilt) patches?
Which files/patches?

---
~Randy