Re: [Ext2-devel] [PATCH 1/9] extents for ext4

Mingming Cao
2006-08-11T22:13:28Z

On Thu, 2006-08-10 at 11:00 -0700, Andrew Morton wrote:
> On Thu, 10 Aug 2006 13:17:55 -0400
> Theodore Tso <tytso@mit.edu> wrote:
>
> > On Wed, Aug 09, 2006 at 11:39:40PM -0700, Andrew Morton wrote:
> > > - replace all brelse() calls with put_bh(). Because brelse() is
> > > old-fashioned, has a weird name and neelessly permits a NULL arg.
> > >
> > > In fact it would be beter to convert JBD and ext3 to put_bh before
> > > copying it all over.
> >
> > Wouldn't it be better to preserve in the source code history the
> > brelse->put_bh conversion? We can pour a huge number of changes in
> > ext4 before we submit, but I would have thought it would be easier for
> > everyone to see what is going on if we submit with just the minimal
> > changes, and then have patches that address concerns like this one at
> > a time.
> >
>
> I'd suggest that this be one of the cleanups which be done within ext3
> before taking the ext4 copy.

Looked at this today -- currently brelse() and __brelse() will check the
b_count before calling put_bh(). I think it's okay to replace put_bh()
without checking the b_count, as we always call put_bh() with get_bh
()....but want to confirm with you.

Mingming