From: "Jan Beulich" <jbeulich@novell.com>
To: "Andi Kleen" <ak@suse.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for review] [127/145] i386: move kernel_thread_helper into entry.S
Date: Tue, 15 Aug 2006 12:36:44 +0200 [thread overview]
Message-ID: <44E1BFDC.76E4.0078.0@novell.com> (raw)
Just like done in the x86-64 patch that I just sent, I'd recommend
moving
the push added yesterday outside of the CFI-covered region (so that
in the unlikely event of being caught at the push there won't be an
ill
assumption that a [fake] return address is already on the stack, or
that
there is a return address at all):
ENTRY(kernel_thread_helper)
pushl $0 # fake return address
CFI_STARTPROC
movl %edx,%eax
pushl %edx
CFI_ADJUST_CFA_OFFSET 4
call *%ebx
pushl %eax
CFI_ADJUST_CFA_OFFSET 4
call do_exit
CFI_ENDPROC
ENDPROC(kernel_thread_helper)
Jan
next reply other threads:[~2006-08-15 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 10:36 Jan Beulich [this message]
2006-08-15 10:48 ` [PATCH for review] [127/145] i386: move kernel_thread_helper into entry.S Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2006-08-14 12:36 Jan Beulich
2006-08-14 12:39 ` Andi Kleen
[not found] <20060810 935.775038000@suse.de>
2006-08-10 19:37 ` Andi Kleen
2006-08-11 8:33 ` Jan Beulich
2006-08-11 8:38 ` Andi Kleen
2006-08-11 9:48 ` Jan Beulich
2006-08-11 10:16 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E1BFDC.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox