Re: PATCH/FIX for drivers/cdrom/cdrom.c

Lennart Sorensen
2006-08-17T14:37:09Z

On Thu, Aug 17, 2006 at 02:48:50PM +0100, Alan Cox wrote:
> Ar Iau, 2006-08-17 am 09:23 -0400, ysgrifennodd Lennart Sorensen:
> > Why can't O_EXCL mean that the kernel prevents anyone else from issuing
> > ioctl's to the device? One would think that is the meaning of exlusive.
>
> If you were designing a new OS from scratch you might want to explore
> that semantic as a design idea. I wouldn't recommend it because a lot of
> apps will be upset if they issue an ioctl and it mysteriously fails or
> hangs.

I think hal should get an error when it tries to open the cdrom device
when the burning application is using it. It shouldn't even get a
chance to issue an ioctl. I was assuming hal doesn't keep the cdrom
device open at all times (if it does, well that would be stupid).

> Issues of this nature require high level synchronization and that
> (witness email) is generally done in user space which is the only place
> that has transaction level visibility.

Hmm, so how does one tell hal to go to hell and leave the cdrom device
alone at all times (other than totally disabling hal). Who the heck
wants all that stupid auto crap anyhow. :)

--
Len Sorensen