public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: Dmitry Torokhov <dtor@insightbb.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: RFC-patch - make sysfs_create_group skip members with attr.mode == 0
Date: Fri, 18 Aug 2006 23:21:11 -0600	[thread overview]
Message-ID: <44E69FC7.2040406@gmail.com> (raw)
In-Reply-To: <200608190019.01389.dtor@insightbb.com>

Dmitry Torokhov wrote:
> On Friday 18 August 2006 00:25, Jim Cromie wrote:
>   
>> With this patch, atts 4..N can be disabled at runtime,
>> by setting mode = 0.  Afterwards, when sysfs_group_create
>> is called, it creates attr-files *only* for those whose
>> mode != 0.  IOW - no attr-files for non-existent hardware.
>> Normally, mode is set usefully, and attr-files
>> are created as normal.
>>
>>     
patch trimmed
>
> Unfortunately this does not work too well if your box happen to have
> 2 or more different chips served by the same driver as you fiddle with
> the static array of attributes shared by all device instances.
>
>   

Ack, yes.  Thats become clear over on lm-sensors.
Kinda spoils the supposed generality..

thanks

      parent reply	other threads:[~2006-08-19  5:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-17 22:50 RFC-patch - make sysfs_create_group skip members with attr.mode == 0 Jim Cromie
2006-08-18  1:49 ` Alexey Dobriyan
2006-08-18  4:25   ` Jim Cromie
     [not found]     ` <200608190019.01389.dtor@insightbb.com>
2006-08-19  5:21       ` Jim Cromie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44E69FC7.2040406@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=dtor@insightbb.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox