From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, drzeus-sdhci@drzeus.cx
Subject: Re: [Patch] Signedness issue in drivers/net/phy/phy_device.c
Date: Sun, 20 Aug 2006 06:12:02 +0200 [thread overview]
Message-ID: <44E7E112.3010500@student.ltu.se> (raw)
In-Reply-To: <1156008815.18192.3.camel@alice>
Eric Sesterhenn wrote:
>hi,
>
>
hello
>while checking gcc 4.1 -Wextra warnings, I stumbled across the following
>two warnings:
>
>drivers/net/phy/phy_device.c:528: warning: comparison of unsigned expression < 0 is always false
>drivers/net/phy/phy_device.c:546: warning: comparison of unsigned expression < 0 is always false
>
>Since phy_read() returns an integer and can return negative values, it
>seems to me the best way to get proper error handling working again
>is to make val an int. Currently it is an u32, so the < 0 check
>always fails.
>
>Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
>--- linux-2.6.18-rc4/drivers/net/phy/phy_device.c.orig 2006-08-19 18:22:56.000000000 +0200
>+++ linux-2.6.18-rc4/drivers/net/phy/phy_device.c 2006-08-19 18:24:49.000000000 +0200
>@@ -513,7 +513,7 @@ EXPORT_SYMBOL(genphy_read_status);
>
> static int genphy_config_init(struct phy_device *phydev)
> {
>- u32 val;
>+ int val;
>
>
Would it not be preferable to use a 's32' instead of an 'int'? After
all, it seem 'val' needs to be 32 bits.
Just a thought
/Richard
next prev parent reply other threads:[~2006-08-20 4:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-19 17:33 [Patch] Signedness issue in drivers/net/phy/phy_device.c Eric Sesterhenn
2006-08-20 4:12 ` Richard Knutsson [this message]
2006-08-20 18:36 ` Eric Sesterhenn / Snakebyte
2006-08-20 19:16 ` Dave Jones
2006-08-20 20:39 ` Eric Sesterhenn
2006-08-20 20:26 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E7E112.3010500@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=drzeus-sdhci@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox