public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Paul Drynoff <pauldrynoff@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Jeremy Fitzhardinge <jeremy@xensource.com>,
	linux-kernel@vger.kernel.org, Zachary Amsden <zach@vmware.com>
Subject: Re: [BUG] Can not boot linux-2.6.18-rc4-mm2
Date: Wed, 23 Aug 2006 08:07:13 -0700	[thread overview]
Message-ID: <44EC6F21.9090000@goop.org> (raw)
In-Reply-To: <36e6b2150608222127y39bb9314h9b0a31f1f8b6b399@mail.gmail.com>

Paul Drynoff wrote:
> On 8/23/06, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>> Hm.  Try this:
>> --- a/arch/i386/kernel/paravirt.c
>> +++ b/arch/i386/kernel/paravirt.c
> I have no such file.
>
>> --- a/include/asm-i386/desc.h
>> +++ b/include/asm-i386/desc.h
>> @@ -97,7 +97,7 @@ static inline void set_ldt(const void *a
>>         __u32 low, high;
>>
>>         pack_descriptor(&low, &high, (unsigned long)addr,
>> -                       entries * sizeof(struct desc_struct) - 1,
>> +                       entries * sizeof(struct desc_struct),
>>                         DESCTYPE_LDT, 0);
>>         write_gdt_entry(get_cpu_gdt_table(cpu), GDT_ENTRY_LDT, low, 
>> high);
>
> There is no such code in this file.

Ah, yes, that was against a different patch queue.

> I adopt your code for linux-2.6.18-rc4-mm2, and looks like it fix bug.
>
> Index: linux-2.6.18-rc4-mm2/include/asm-i386/desc.h
> ===================================================================
> --- linux-2.6.18-rc4-mm2.orig/include/asm-i386/desc.h
> +++ linux-2.6.18-rc4-mm2/include/asm-i386/desc.h
> @@ -114,7 +114,7 @@ static inline void set_ldt_desc(unsigned
> {
>        __u32 a, b;
>        pack_descriptor(&a, &b, (unsigned long)addr,
> -                       entries * sizeof(struct desc_struct) - 1,
> +                       entries * sizeof(struct desc_struct),
>                        DESCTYPE_LDT, 0);
>        write_gdt_entry(get_cpu_gdt_table(cpu), GDT_ENTRY_LDT, a, b);
> }

Great!

    J

  reply	other threads:[~2006-08-23 15:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-22  8:51 [BUG] Can not boot linux-2.6.18-rc4-mm2 Paul Drynoff
2006-08-22 16:50 ` Paul Drynoff
2006-08-22 21:14   ` Frederik Deweerdt
2006-08-22 21:14     ` Paul Drynoff
2006-08-22 19:38 ` Andrew Morton
2006-08-22 21:13   ` Paul Drynoff
2006-08-22 21:54     ` Jeremy Fitzhardinge
2006-08-23  4:27       ` Paul Drynoff
2006-08-23 15:07         ` Jeremy Fitzhardinge [this message]
2006-08-23  4:36   ` Paul Drynoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44EC6F21.9090000@goop.org \
    --to=jeremy@goop.org \
    --cc=akpm@osdl.org \
    --cc=jeremy@xensource.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pauldrynoff@gmail.com \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox