From: Paul Fulghum <paulkf@microgate.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: drivers/char/synclink_gt.c: chars don't have more than 8 bits
Date: Fri, 25 Aug 2006 21:49:22 -0500 [thread overview]
Message-ID: <44EFB6B2.205@microgate.com> (raw)
In-Reply-To: <20060826020123.GB4765@stusta.de>
Adrian Bunk wrote:
> The GNU C compiler (SVN version) spotted the following buggy code in
> drivers/char/synclink_gt.c:
> ...
> Since there are no bits 8 or 9 in a char this code is currently
> dead code.
Yes, that is a bug.
Status and data come in byte pairs, bits 9 and 8 are
referenced from the 16 bit combination.
The code is operating on individual bytes in the buffer,
so it should be bits 1 and 0 that are tested.
I will make a patch and post it.
Thanks,
Paul
next prev parent reply other threads:[~2006-08-26 2:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-26 2:01 drivers/char/synclink_gt.c: chars don't have more than 8 bits Adrian Bunk
2006-08-26 2:49 ` Paul Fulghum [this message]
2006-08-28 19:07 ` [PATCH] synclink_gt fix receive tty error handling Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44EFB6B2.205@microgate.com \
--to=paulkf@microgate.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox