Re: [PATCH 2.6.18-rc4-mm2] fs/jfs: Conversion to generic boolean

Dave Kleikamp
2006-08-29T13:53:15Z

On Tue, 2006-08-29 at 15:48 +0200, Richard Knutsson wrote:
> Dave Kleikamp wrote:
>
> >On Tue, 2006-08-29 at 01:33 +0200, Richard Knutsson wrote:

> >>What do you say, can you hold on it for a while (can't be urgent, can
> >>it?) and see how the conversion go. Will take time for it during this
> >>week(end) and if the result is that almost no maintainer wants it, then...
> >>Just seem strange to having a boolean function but declaring it integer,
> >>for (in my knowledge) no reason.
> >>
> >>
> >
> >Sounds good to me. I think I'll go ahead and kill the use of TRUE and
> >FALSE, but hold off on the type change for now.
> >
> >
> To 0/1 or false/true?

I was going to go ahead with the 0/1 thing, but on second thought, I'll
just hold off on the whole thing and see where this ends up. I may go
ahead and just accept your original patch. We lived with the ugly,
locally-defined TRUE & FALSE this long. Waiting a little longer can't
hurt.