From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFT] sched.h removal from module.h
Date: Tue, 29 Aug 2006 11:10:27 +1000 [thread overview]
Message-ID: <44F39403.4060909@yahoo.com.au> (raw)
In-Reply-To: <20060827153234.GA31505@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> I don't have compile-kernel-in-a-minute box, so
>
> Please, test on your usual configs and send me _new_ warnings and errors
> that appeared.
>
> Patch seems to pass [alpha, i386, x86_64] x [allmodconfig-SMP, -UP] without
> regressions.
>
> [PATCH] sched.h removal from module.h
>
> This is done by duplicating prototype of wake_up_process() which seems
> to be the only thing module.h wants.
This is really ugly, IMO. It makes the code less maintainable, so I don't
think there is any point in doing it. In this case, we really do want to
use scheduler functions, so the thing you do in that case is to include
sched.h, not declare them yourself :(
If you are particularly concerned about this, just move all those refcount
inlines into kernel/module.c (they're too big anyway)... then you can drop
the sched.h include from module.h for free ;)
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-08-29 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-27 15:32 [RFT] sched.h removal from module.h Alexey Dobriyan
2006-08-29 1:10 ` Nick Piggin [this message]
2006-08-29 11:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F39403.4060909@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox