public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: sergio@sergiomb.no-ip.org
Cc: bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Andrew Morton <akpm@osdl.org>, Chris Wedgwood <cw@f00f.org>,
	greg@kroah.com, jeff@garzik.org, harmon@ksu.edu
Subject: Re: [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2
Date: Tue, 29 Aug 2006 23:46:18 -0400	[thread overview]
Message-ID: <44F50A0A.2040800@gentoo.org> (raw)
In-Reply-To: <1156906638.3022.18.camel@localhost.portugal>

Sergio Monteiro Basto wrote:
> I remember check my emails that I send to Len Brown about this subject.
> And I found, what I want, is just revert one patch of Bjorn Helgaas :)
> between kernel 2.6.12-rc5 and 6.13.

It does look like this patch was under discussion of being reverted 
before. See http://lkml.org/lkml/2005/9/26/183

The following comment still stands when we just revert Bjorn's change:

>> I'm reasonably certain that this patch will apply the quirks on the 
>> affected systems again, so I'm happy for it to be applied, people will 
>> be able to use their hardware again. However I'm not sure how good a 
>> solution it is, because in some circumstances it will apply the quirks 
>> to VIA PCI cards on non-VIA boards, which was the reason we messed with 
>> this code in the first place. We could possibly merge it with the 
>> southbridge detection hack, but it gets a bit silly at that point...

So perhaps the best solution is a combination of reverting Bjorn's 
patch, adding Linus' suggested change, and adding my southbridge hack.

Daniel

  reply	other threads:[~2006-08-30  3:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-28 13:01 [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2 Sergio Monteiro Basto
2006-07-28 19:24 ` Andrew Morton
2006-07-29  3:52   ` Sergio Monteiro Basto
2006-08-12 22:47 ` Daniel Drake
2006-08-30  2:57   ` Sergio Monteiro Basto
2006-08-30  3:46     ` Daniel Drake [this message]
2006-08-30 11:25       ` Sergio Monteiro Basto
2006-08-30 16:13         ` Daniel Drake
2006-08-31 11:33           ` Sergio Monteiro Basto
2006-09-05 13:37             ` Daniel Drake
2006-09-05 14:49               ` Sergio Monteiro Basto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44F50A0A.2040800@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bjorn.helgaas@hp.com \
    --cc=cw@f00f.org \
    --cc=greg@kroah.com \
    --cc=harmon@ksu.edu \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio@sergiomb.no-ip.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox