public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: Sergio Monteiro Basto <sergio@sergiomb.no-ip.org>
Cc: bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Andrew Morton <akpm@osdl.org>, Chris Wedgwood <cw@f00f.org>,
	greg@kroah.com, jeff@garzik.org, harmon@ksu.edu
Subject: Re: [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2
Date: Wed, 30 Aug 2006 12:13:39 -0400	[thread overview]
Message-ID: <44F5B933.2010608@gentoo.org> (raw)
In-Reply-To: <1156937128.2624.6.camel@localhost.localdomain>

Sergio Monteiro Basto wrote:
>> It does look like this patch was under discussion of being reverted 
>> before. See http://lkml.org/lkml/2005/9/26/183
> 
> To be honest, I prefer put again this :
> 
>  +#ifdef CONFIG_X86_IO_APIC
>  +      if (nr_ioapics && !skip_ioapic_setup)
>  +              return;
>  +#endif
>  +#ifdef CONFIG_ACPI
>  +      if (acpi_irq_model != ACPI_IRQ_MODEL_PIC)
>  +              return;
>  +#endif

Isn't this exactly the same as what was being suggested?

> about Linus suggestion : 
> -	new_irq = dev->irq & 0xf;
> +	new_irq = dev->irq;
> +	if (!new_irq || new_irq >= 15)
> +		return;
> 
> no, we have problem with VIA SATA controllers which have irq lower than
> 15 

Any chance you can provide a link to this example so that we can 
document the decision in the commit message?

Thanks,
Daniel


  reply	other threads:[~2006-08-31  3:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-28 13:01 [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2 Sergio Monteiro Basto
2006-07-28 19:24 ` Andrew Morton
2006-07-29  3:52   ` Sergio Monteiro Basto
2006-08-12 22:47 ` Daniel Drake
2006-08-30  2:57   ` Sergio Monteiro Basto
2006-08-30  3:46     ` Daniel Drake
2006-08-30 11:25       ` Sergio Monteiro Basto
2006-08-30 16:13         ` Daniel Drake [this message]
2006-08-31 11:33           ` Sergio Monteiro Basto
2006-09-05 13:37             ` Daniel Drake
2006-09-05 14:49               ` Sergio Monteiro Basto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44F5B933.2010608@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bjorn.helgaas@hp.com \
    --cc=cw@f00f.org \
    --cc=greg@kroah.com \
    --cc=harmon@ksu.edu \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergio@sergiomb.no-ip.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox