From: Zach Brown <zab@zabbo.net>
To: Yi Yang <yang.y.yi@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
linux-aio <linux-aio@kvack.org>,
torvalds@osdl.org
Subject: Re: [2.6.18-rc5 PATCH]: aio cleanup
Date: Wed, 30 Aug 2006 09:30:00 -0700 [thread overview]
Message-ID: <44F5BD08.1020700@zabbo.net> (raw)
In-Reply-To: <44F59E79.2080402@gmail.com>
Yi Yang wrote:
> As Zach Brown said, a cleanup patch is reasonable. Here it is.
I said a cleanup patch could be reasonable :)
> This patch extracts the common part from aio_fsync and aio_fdsync
> and define a new inlined function aio_xsync, then aio_fsync and
> aio_fdsync just call aio_xsunc in the almost same way except second
> argument is different, one is 1 and another 0.
I don't think we need to change this, to be honest. They're tiny
functions without users. It doesn't seem worth the trouble, minimal
though it is.
Maybe if we had ->aio_fsync() users it would be more clear if there was
an opportunity to really clarify the interface.
- z
next prev parent reply other threads:[~2006-08-30 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 13:21 [2.6.18-rc* PATCH RFC]: Correct ambiguous errno of aio Yi Yang
2006-08-29 18:32 ` Zach Brown
2006-08-29 19:04 ` Benjamin LaHaise
2006-08-30 14:19 ` [2.6.18-rc5 PATCH]: aio cleanup Yi Yang
2006-08-30 16:30 ` Zach Brown [this message]
[not found] ` <4c4443230608300651n34e8dbbdn8749c6874ce8791@mail.gmail.com>
2006-08-30 16:35 ` [2.6.18-rc* PATCH RFC]: Correct ambiguous errno of aio Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F5BD08.1020700@zabbo.net \
--to=zab@zabbo.net \
--cc=akpm@osdl.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=yang.y.yi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox