public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: "Darrick J. Wong" <djwong@us.ibm.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] aic94xx: Increase can_queue for better performance
Date: Wed, 30 Aug 2006 14:18:33 -0700	[thread overview]
Message-ID: <44F600A9.4050207@us.ibm.com> (raw)
In-Reply-To: <44F5FB54.5010700@us.ibm.com>

Darrick J. Wong wrote:
> Hi all,
> 
> Below is a patch that sets can_queue in the aic94xx driver's scsi_host
> to better performing values than what's there currently.  It seems that
> asd_ha->seq.can_queue reflects the number of requests that can be
> queued per controller; so long as there's one scsi_host per controller,
> it seems logical that the scsi_host ought to have the same can_queue
> value.  To the best of my (still limited) knowledge, this method
> provides the correct value.
> 
> The effect of leaving this value set to 1 is terrible performance in
> the case of either (a) certain Maxtor SAS drives flying solo or (b)
> flooding several disks with I/O simultaneously (md-raid).  There may be
> more scenarios where we see similar problems that I haven't uncovered.

Let's try this again, after kicking Thunderbird in the head.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>

diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
index 3e25e31..5c6d457 100644
--- a/drivers/scsi/aic94xx/aic94xx_init.c
+++ b/drivers/scsi/aic94xx/aic94xx_init.c
@@ -623,6 +623,8 @@ static int __devinit asd_pci_probe(struc
 		   asd_ha->hw_prof.bios.present ? "build " : "not present",
 		   asd_ha->hw_prof.bios.bld);
 
+	shost->can_queue = asd_ha->seq.can_queue;
+
 	if (use_msi)
 		pci_enable_msi(asd_ha->pcidev);
 

      reply	other threads:[~2006-08-30 21:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-29  5:23 [PATCH] aic94xx: Increase can_queue and cmds_per_lun Darrick J. Wong
2006-08-30 17:19 ` James Bottomley
2006-08-30 19:03   ` Darrick J. Wong
2006-08-30 19:03   ` Darrick J. Wong
2006-08-30 19:04 ` Luben Tuikov
2006-08-30 19:25   ` James Bottomley
2006-08-31  5:29     ` Luben Tuikov
2006-08-30 20:55   ` [PATCH v3] aic94xx: Increase can_queue for better performance Darrick J. Wong
2006-08-30 21:18     ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44F600A9.4050207@us.ibm.com \
    --to=djwong@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox