From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Pavel Machek <pavel@suse.cz>
Cc: Andrew Morton <akpm@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: cpu_init is called during resume
Date: Thu, 31 Aug 2006 09:11:55 -0700 [thread overview]
Message-ID: <44F70A4B.4090803@goop.org> (raw)
In-Reply-To: <20060831135545.GM3923@elf.ucw.cz>
Pavel Machek wrote:
> cpu_init() is called during resume, at time when GFP_KERNEL is not
> available. This silences warning, and adds few small cleanups.
>
I presume this is resume from disk. If you're doing resume from RAM,
all the CPU-related stuff should already be allocated, unless you're
bringing up a new CPU which wasn't previously there, right?
What's the call path for this on resume? In my i386-pda patches, I've
rearranged this so that the secondary CPU's GDT (and PDA) are
pre-allocated on the boot CPU. Does this help this case, or would they
still need to be atomic allocations?
And wouldn't making these allocations atomic make real CPU hotplug (ie,
on an active, running system) more likely to fail? This code doesn't
deal with allocation failure very elegantly.
J
next prev parent reply other threads:[~2006-08-31 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 13:55 cpu_init is called during resume Pavel Machek
2006-08-31 16:11 ` Jeremy Fitzhardinge [this message]
2006-08-31 22:31 ` Pavel Machek
2006-08-31 23:52 ` Jeremy Fitzhardinge
2006-09-02 11:21 ` Pavel Machek
2006-09-03 0:00 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F70A4B.4090803@goop.org \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox