Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.

Jeremy Fitzhardinge
2006-08-31T21:39:47Z

Ian Campbell wrote:
> Are you sure that works? When I tried it didn't. I think because
> asm/smp.h isn't included by linux/smp.h for !SMP.
>

Nah, testing is overrated.

> I needed the below to make it work, but including linux/smp.h and
> asm/smp.h in the same file smells a bit fishy to me... Probably
> acceptable for now if you are thinking of redoing SMP processor bringup
> anyway.
>

That looks OK for now. Rearranging CPU bringup looks a little bit
complex to do immediately, so this seems like a reasonable fix for now.

J