Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.

Jeremy Fitzhardinge
2006-08-31T19:10:38Z

Ian Campbell wrote:
> smp_processor_id() is defined for !SMP in include/linux/smp.h, I don't
> know if it would be appropriate to add early_smp_processor_id() there
> since it seems i386 specific. asm/smp.h isn't included by linux/smp.h
> when !SMP but you could add an explicit include to common.c I suppose.
>
The simple solution is to just define a !SMP version of
early_smp_processor_id(). It's i386 specific, but that's the only arch
that uses it:

diff -r 8a89489b3734 include/asm-i386/smp.h
--- a/include/asm-i386/smp.h Thu Aug 31 12:06:44 2006 -0700
+++ b/include/asm-i386/smp.h Thu Aug 31 12:07:48 2006 -0700
@@ -98,6 +98,7 @@ extern unsigned int num_processors;
#else /* CONFIG_SMP */

#define safe_smp_processor_id() 0
+#define early_smp_processor_id() 0
#define cpu_physical_id(cpu) boot_cpu_physical_apicid

#define NO_PROC_ID 0xFF /* No processor magic marker */

J