From: Paul Fulghum <paulkf@microgate.com>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Uninitialized variable in drivers/net/wan/syncppp.c
Date: Thu, 31 Aug 2006 20:01:59 -0500 [thread overview]
Message-ID: <44F78687.7080805@microgate.com> (raw)
In-Reply-To: <1157070362.14246.2.camel@alice>
Eric Sesterhenn wrote:
> Thanks for clarification. Here is an updated patch, which has the advantage
> of also silencing the gcc warning.
>
> For len equal to 4, we never call sppp_lcp_conf_parse_options(),
> therefore rmagic does not get initialized.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.18-rc5/drivers/net/wan/syncppp.c.orig 2006-09-01 02:16:18.000000000 +0200
> +++ linux-2.6.18-rc5/drivers/net/wan/syncppp.c 2006-09-01 02:16:40.000000000 +0200
> @@ -469,7 +469,7 @@ static void sppp_lcp_input (struct sppp
> struct net_device *dev = sp->pp_if;
> int len = skb->len;
> u8 *p, opt[6];
> - u32 rmagic;
> + u32 rmagic = 0;
>
> if (!pskb_may_pull(skb, sizeof(struct lcp_header))) {
> if (sp->pp_flags & PP_DEBUG)
Acked-by: Paul Fulghum <paulkf@microgate.com>
prev parent reply other threads:[~2006-09-01 1:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 23:13 [Patch] Uninitialized variable in drivers/net/wan/syncppp.c Eric Sesterhenn
2006-08-31 23:45 ` Paul Fulghum
2006-09-01 0:26 ` Eric Sesterhenn
2006-09-01 1:01 ` Paul Fulghum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F78687.7080805@microgate.com \
--to=paulkf@microgate.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox