From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Type checking for write_pda()
Date: Thu, 31 Aug 2006 18:37:58 -0700 [thread overview]
Message-ID: <44F78EF6.1060701@goop.org> (raw)
I just added type checking for assignments the PDA in the i386 PDA code.
Here's the x86-64 equivalent. (Obviously this doesn't contain the latest
x86-64 PDA change.)
Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
diff -r 77945c3646ac include/asm-x86_64/pda.h
--- a/include/asm-x86_64/pda.h Thu Aug 31 18:30:26 2006 -0700
+++ b/include/asm-x86_64/pda.h Thu Aug 31 18:34:49 2006 -0700
@@ -47,6 +47,7 @@ extern void __bad_pda_field(void);
#define pda_to_op(op,field,val) do { \
typedef typeof_field(struct x8664_pda, field) T__; \
+ if (0) { T__ tmp__; tmp__ = (val); } \
switch (sizeof_field(struct x8664_pda, field)) { \
case 2: \
asm volatile(op "w %0,%%gs:%P1"::"ri" ((T__)val),"i"(pda_offset(field)):"memory"); break; \
next reply other threads:[~2006-09-01 1:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 1:37 Jeremy Fitzhardinge [this message]
2006-09-01 7:56 ` Type checking for write_pda() Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F78EF6.1060701@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox