From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: akpm@osdl.org, sfrench@samba.org,
linux-cifs-client@lists.samba.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18-rc4-mm3 1/2] fs/cifs: Converting into generic boolean
Date: Fri, 01 Sep 2006 15:42:58 +0200 [thread overview]
Message-ID: <44F838E2.2010908@student.ltu.se> (raw)
In-Reply-To: <Pine.LNX.4.61.0609011518030.21826@yvahk01.tjqt.qr>
Jan Engelhardt wrote:
>>--- a/fs/cifs/asn1.c 2006-09-01 01:24:45.000000000 +0200
>>+++ b/fs/cifs/asn1.c 2006-09-01 02:43:09.000000000 +0200
>>@@ -457,7 +457,7 @@ decode_negTokenInit(unsigned char *secur
>>unsigned char *sequence_end;
>>unsigned long *oid = NULL;
>>unsigned int cls, con, tag, oidlen, rc;
>>- int use_ntlmssp = FALSE;
>>+ int use_ntlmssp = false;
>>
>>
>
>Should not this become 'bool use_ntlmssp'? Possibly in a later patch?
>
>
I would like to, but there has been complaints on changing 'int''s into
'bool''s, so until there is a more formal decision on this...
Of course I would be happy to make a 'int'->'bool'-patch if a maintainer
wants it.
>
>Jan Engelhardt
>
>
Richard Knutsson
next prev parent reply other threads:[~2006-09-01 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 13:19 [PATCH 2.6.18-rc4-mm3 1/2] fs/cifs: Converting into generic boolean Richard Knutsson
2006-09-01 13:19 ` Jan Engelhardt
2006-09-01 13:42 ` Richard Knutsson [this message]
[not found] <OFE86A755F.DEA60E1E-ON872571DC.00732934-862571DC.00739039@us.ibm.com>
2006-09-02 7:18 ` Jan Engelhardt
[not found] <OF54100A15.CFE2FA3E-ON872571DC.0073878E-862571DC.0073AAFB@us.ibm.com>
2006-09-04 12:33 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F838E2.2010908@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=akpm@osdl.org \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox