public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bas Bloemsaat <bas.bloemsaat@gmail.com>
To: mchehab@infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Vicam driver, device
Date: Sun, 03 Sep 2006 10:38:43 +0200	[thread overview]
Message-ID: <44FA9493.1090207@gmail.com> (raw)
In-Reply-To: <7c4668e50609030111i5f3cb079j76e9c8651cf8d6b4@mail.gmail.com>

Hi,

> Although this is really a trivial patch, it would be nice if you can
> sign your patch (on our wiki you can have more info about patch
> 
> Also, it would be nice if you add a comment above the new entry at vicam
> PCI table a short comment describing the new device, like, for example:
Done. I put a line under the current one describing the cam it was developed for.

And mailed the text without wrapping (thanks to Pavel for bringing that to my attention).

Regards,
Bas

Description:
Trivial patch to make Compro PS39U WebCam work with linux by using the vicam driver.
The camera is just a vicam with another USB ID, so I added that ID to the driver, and it works now.

Signed-off-by: Bas Bloemsaat <bas.bloemsaat@gmail.com>


--- drivers/media/video/usbvideo/vicam.c.org	2006-09-03 10:19:06.000000000 +0200
+++ drivers/media/video/usbvideo/vicam.c	2006-09-03 10:22:52.000000000 +0200
@@ -7,6 +7,7 @@
   *                    Monroe Williams (monroe@pobox.com)
   *
   * Supports 3COM HomeConnect PC Digital WebCam
+ * Supports Compro PS39U WebCam
   *
   * This program is free software; you can redistribute it and/or modify
   * it under the terms of the GNU General Public License as published by
@@ -60,6 +61,8 @@
  /* Define these values to match your device */
  #define USB_VICAM_VENDOR_ID	0x04c1
  #define USB_VICAM_PRODUCT_ID	0x009d
+#define USB_COMPRO_VENDOR_ID	0x0602
+#define USB_COMPRO_PRODUCT_ID	0x1001

  #define VICAM_BYTES_PER_PIXEL   3
  #define VICAM_MAX_READ_SIZE     (512*242+128)
@@ -1254,6 +1257,7 @@ static struct video_device vicam_templat
  /* table of devices that work with this driver */
  static struct usb_device_id vicam_table[] = {
  	{USB_DEVICE(USB_VICAM_VENDOR_ID, USB_VICAM_PRODUCT_ID)},
+	{USB_DEVICE(USB_COMPRO_VENDOR_ID, USB_COMPRO_PRODUCT_ID)},
  	{}			/* Terminating entry */
  };


-- 
VGER BF report: U 0.954643

  parent reply	other threads:[~2006-09-03  8:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-02 18:01 [PATCH] Vicam driver, device Bas Bloemsaat
2006-09-02 18:12 ` Mauro Carvalho Chehab
     [not found]   ` <7c4668e50609030111i5f3cb079j76e9c8651cf8d6b4@mail.gmail.com>
2006-09-03  8:38     ` Bas Bloemsaat [this message]
2006-09-03 16:30       ` Nick Warne
     [not found]         ` <7c4668e50609041128j4e382815me92cdbabb53d662d@mail.gmail.com>
2006-09-04 18:35           ` Nick Warne
2006-09-02 19:55 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44FA9493.1090207@gmail.com \
    --to=bas.bloemsaat@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox