Re: [PATCH] fix creating zero sized bio mempools in low memory system

Jens Axboe
2006-09-04T12:40:26Z

On Mon, Sep 04 2006, Milan Broz wrote:
> In the very low memory systems is in the init_bio call
> scale parameter set to zero and it leads to creating
> zero sized mempool.
>
> This patch prevents pool_entries parameter become zero,
> so the created pool have at least 1 entry.
>
> Mempool with 0 entries lead to incorrect behaviour
> of mempool_free. (Alloc requests are not waken up
> and system stalls in mempool_alloc->ioschedule).

Good catch, queued. Maybe this is the only such scaling problem,
otherwise it may be a good idea to add a WARN_ON(!min_nr) to the mempool
setup in mm/mempool.c to catch such errors.

--
Jens Axboe