From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Nathan Scott <nathans@sgi.com>
Cc: akpm@osdl.org, xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [xfs-masters] Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Converting into generic boolean
Date: Wed, 06 Sep 2006 02:23:09 +0200 [thread overview]
Message-ID: <44FE14ED.3020605@student.ltu.se> (raw)
In-Reply-To: <20060906091407.M3365803@wobbly.melbourne.sgi.com>
Nathan Scott wrote:
>On Tue, Sep 05, 2006 at 02:47:02PM +0200, Richard Knutsson wrote:
>
>
>>Just the notion: "your" guys was the ones to make those to boolean(_t),
>>
>>
>
>Sort of, we actually inherited that type from IRIX where it is
>defined in <sys/types.h>.
>
>
Oh, ok
>>>"int needflush;" is just as readable (some would argue moreso) as
>>>"bool needflush;" and thats pretty much the level of use in XFS -
>>>
>>>
>>>
>>How are you sure "needflush" is, for example, not a counter?
>>
>>
>
>Well, that would be named "flushcount" or some such thing. And you
>would be able to tell that it was a counter by the way its used in
>the surrounding code.
>
>
True, thinking more of when you have a quick look at the headers, but
"flushcount" would be a more logical name in such a case.
>This discussion really isn't going anywhere useful; I think you need
>to accept that not everyone sees value in a boolean type. :)
>
>
Well, can you blame me for trying? ;)
But the more important thing is to clean up the boolean-type and
FALSE/TRUE mess in the kernel.
>cheers.
>
>
Thank you for your time and happy coding :)
prev parent reply other threads:[~2006-09-06 0:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 13:21 [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Converting into generic boolean Richard Knutsson
2006-09-04 5:02 ` Nathan Scott
2006-09-04 10:24 ` Richard Knutsson
2006-09-05 3:05 ` Nathan Scott
2006-09-05 12:47 ` Richard Knutsson
2006-09-05 23:14 ` [xfs-masters] " Nathan Scott
2006-09-06 0:23 ` Richard Knutsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FE14ED.3020605@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathans@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox