From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Aubrey <aubreylee@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, mpm@selenic.com,
davidm@snapgear.com, gerg@snapgear.com
Subject: Re: kernel BUGs when removing largish files with the SLOB allocator
Date: Wed, 06 Sep 2006 13:36:02 +1000 [thread overview]
Message-ID: <44FE4222.3080106@yahoo.com.au> (raw)
In-Reply-To: <6d6a94c50609051935m607f976j942263dd1ac9c4fb@mail.gmail.com>
Aubrey wrote:
> Yeah, I agree with most of your opinion. Using PG_slab is really a
> quickest way to determine the size of the object. But I think using a
> flag named "PG_slab" on a memory algorithm named "slob" seems not
> reasonable. It may confuse the people who start to read the kernel
> source code. So I'm writing to ask if there is a better solution to
> fix the issue.
No, confusing would be a "slab replacement" that doesn't provide the same
API as slab and thus requires users to use ifdefs.
I've already suggested exact same thing as David in the exact same situation
about 6 months ago. It is the right way to go.
--
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-09-06 3:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 6:56 kernel BUGs when removing largish files with the SLOB allocator Aubrey
2006-09-04 10:21 ` David Howells
2006-09-05 3:52 ` Aubrey
2006-09-05 9:35 ` David Howells
2006-09-06 2:35 ` Aubrey
2006-09-06 3:36 ` Nick Piggin [this message]
2006-09-12 8:07 ` Aubrey
2006-09-12 8:54 ` David Howells
2006-09-12 10:53 ` Aubrey
2006-09-12 17:43 ` Matt Mackall
2006-09-12 19:10 ` David Howells
2006-09-12 20:51 ` Matt Mackall
2006-09-12 20:56 ` David Howells
2006-09-12 21:04 ` Matt Mackall
2006-09-12 21:59 ` David Howells
2006-09-13 19:39 ` Matt Mackall
2006-09-13 2:16 ` Nick Piggin
2006-09-13 7:21 ` Aubrey
2006-09-12 19:25 ` David Howells
2006-09-12 20:28 ` Matt Mackall
2006-09-12 21:02 ` David Howells
2006-09-12 21:15 ` Matt Mackall
2006-09-12 20:49 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FE4222.3080106@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=aubreylee@gmail.com \
--cc=davidm@snapgear.com \
--cc=dhowells@redhat.com \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox