public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kirill Korotaev <dev@sw.ru>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrey Mirkin <amirkin@sw.ru>
Subject: Re: [RFC][PATCH] fail kernel compilation in case of unresolved symbols
Date: Wed, 06 Sep 2006 19:05:10 +0400	[thread overview]
Message-ID: <44FEE3A6.1080009@sw.ru> (raw)
In-Reply-To: <20060905153159.GA13082@uranus.ravnborg.org>

Sam Ravnborg wrote:
> On Tue, Sep 05, 2006 at 05:47:25PM +0400, Kirill Korotaev wrote:
> 
>>At stage 2 modpost utility is used to check modules.
>>In case of unresolved symbols modpost only prints warning.
>>
>>IMHO it is a good idea to fail compilation process in case of
>>unresolved symbols, since usually such errors are left unnoticed,
>>but kernel modules are broken.
> 
> 
> The primary reason why we do not fail in this case is that building
> external modules often result in unresolved symbols at modpost time.
> 
> And there is many legitime uses of external modules that we shall support.
ok. is it ok for you to introduce new Make target 'modules_check'?

Thanks,
Kirill

  parent reply	other threads:[~2006-09-06 15:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-05 13:47 [RFC][PATCH] fail kernel compilation in case of unresolved symbols Kirill Korotaev
2006-09-05 15:31 ` Sam Ravnborg
2006-09-05 16:01   ` Adrian Bunk
2006-09-06 15:05     ` Kirill Korotaev
2006-09-06 15:58       ` Adrian Bunk
2006-09-06 15:05   ` Kirill Korotaev [this message]
2006-09-06 18:15     ` Sam Ravnborg
  -- strict thread matches above, loose matches on Subject: below --
2006-09-05 15:04 Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44FEE3A6.1080009@sw.ru \
    --to=dev@sw.ru \
    --cc=akpm@osdl.org \
    --cc=amirkin@sw.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox