public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Badari Pulavarty <pbadari@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Jan Kara <jack@suse.cz>, Anton Altaparmakov <aia21@cam.ac.uk>,
	sct@redhat.com, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers
Date: Wed, 06 Sep 2006 20:04:27 -0700	[thread overview]
Message-ID: <44FF8C3B.3040505@us.ibm.com> (raw)
In-Reply-To: <20060906191430.7ffcd833.akpm@osdl.org>

Andrew Morton wrote:
> On Wed, 6 Sep 2006 19:27:33 +0200
> Jan Kara <jack@suse.cz> wrote:
>
>   
>>   Ugh! Are you sure? For this path the buffer must be attached (only) to
>> the running transaction. But then how the commit code comes to it?
>> Somebody would have to even manage to refile the buffer from the
>> committing transaction to the running one while the buffer is in wbuf[].
>> Could you check whether someone does __journal_refile_buffer() on your
>> marked buffers, please? Or whether we move buffer to BJ_Locked list in
>> the write_out_data: loop? Thanks.
>>     
>
> The ext3-debug patch will help here.  It records, within the bh, the inputs
> from the last 32 BUFFER_TRACE()s which were run against this bh.  If a
> J_ASSERT fails then you get a nice trace of the last 32 "things" which
> happened to this bh, including the bh's state at that transition.  It
> basically tells you everything you need to know to find the bug.
>
> It's worth spending the time to become familiar with it - I used it a lot in
> early ext3 development.
>   

I will try the patch. Unfortunately, adding more debug is causing the 
problem reproduction
difficult.
> I've been unable to reproduce this crash, btw.  Is there some magic
> incantation apat from running `fsx-linux'?
>   
All I do is on a single 1k filesystem, run 4 copies of fsx (on 4 
different files, ofcourse).
I hit the assert anywhere between 10min-2hours.

Thanks,
Badari


  reply	other threads:[~2006-09-07  3:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-01 15:50 [RFC][PATCH] set_page_buffer_dirty should skip unmapped buffers Badari Pulavarty
2006-09-01 16:12 ` Anton Altaparmakov
2006-09-01 16:32   ` Badari Pulavarty
2006-09-01 17:18     ` Andrew Morton
2006-09-01 17:43       ` Badari Pulavarty
2006-09-01 21:01       ` Badari Pulavarty
2006-09-05 16:11       ` Badari Pulavarty
2006-09-06 12:47         ` Jan Kara
2006-09-06 15:12           ` Badari Pulavarty
2006-09-06 15:34             ` Jan Kara
2006-09-06 16:19               ` Badari Pulavarty
2006-09-06 16:27                 ` Jan Kara
2006-09-06 16:43                   ` Badari Pulavarty
2006-09-06 17:03                     ` Jan Kara
2006-09-06 17:16                   ` Badari Pulavarty
2006-09-06 17:27                     ` Jan Kara
2006-09-07  2:14                       ` Andrew Morton
2006-09-07  3:04                         ` Badari Pulavarty [this message]
2006-09-07  3:34                           ` Andrew Morton
2006-09-07 15:11                       ` Badari Pulavarty
2006-09-07 20:48                         ` Jan Kara
2006-09-07 22:30                         ` Jan Kara
2006-09-08  4:33                           ` Badari Pulavarty
2006-09-08  8:25                             ` Jan Kara
2006-09-08 14:35                               ` Badari Pulavarty
2006-09-11  9:46                                 ` Jan Kara
2006-09-11 20:45                                   ` Badari Pulavarty
2006-09-11 20:52                                     ` Jan Kara
2006-09-13 20:25                           ` Dave Kleikamp
2006-09-14  3:38                             ` Andrew Morton
2006-09-27 22:01                               ` Eric Sandeen
2006-09-28 15:03                                 ` [PATCH] JBD: Make journal_do_submit_data static Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44FF8C3B.3040505@us.ibm.com \
    --to=pbadari@us.ibm.com \
    --cc=aia21@cam.ac.uk \
    --cc=akpm@osdl.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox