From: Jeff Garzik <jeff@garzik.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Tigran Aivazian <tigran@veritas.com>
Subject: Re: [PATCH] x86 microcode: don't check the size
Date: Thu, 07 Sep 2006 00:18:48 -0400 [thread overview]
Message-ID: <44FF9DA8.10007@garzik.org> (raw)
In-Reply-To: <1157597227.2782.55.camel@sli10-desk.sh.intel.com>
Shaohua Li wrote:
> IA32 manual says if micorcode update's size is 0, then the size is
> default size (2048 bytes). But this doesn't suggest all microcode
> update's size should be above 2048 bytes to me. We actually had a
> microcode update whose size is 1024 bytes. The patch just removed the
> check.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Why not explicitly check for zero, rather than removing the questionable
less-than test? The default size logic hasn't disappeared...
Jeff
next prev parent reply other threads:[~2006-09-07 4:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 2:47 [PATCH] x86 microcode: don't check the size Shaohua Li
2006-09-07 4:18 ` Jeff Garzik [this message]
2006-09-07 5:14 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FF9DA8.10007@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=tigran@veritas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox