From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933683AbdEVVBO (ORCPT ); Mon, 22 May 2017 17:01:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54472 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762692AbdEVVBH (ORCPT ); Mon, 22 May 2017 17:01:07 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0992680473 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vyasevic@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0992680473 Reply-To: vyasevic@redhat.com Subject: Re: [PATCH 5/5] sctp: Adjust one function call together with a variable assignment References: <2845df67-d35d-536a-0a53-b2eb83fe1ba5@users.sourceforge.net> <197333e8-b528-ef34-bd16-01e415acdf52@users.sourceforge.net> To: SF Markus Elfring , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Neil Horman , Vlad Yasevich Cc: LKML , kernel-janitors@vger.kernel.org From: Vlad Yasevich Organization: Red Hat Message-ID: <44ba1b0c-8987-8710-a9eb-f13ad31bd966@redhat.com> Date: Mon, 22 May 2017 17:00:59 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <197333e8-b528-ef34-bd16-01e415acdf52@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 22 May 2017 21:01:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/22/2017 12:41 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 18:15:12 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > ERROR: do not use assignment in if condition > > Thus fix the affected source code place. > > Signed-off-by: Markus Elfring > --- > net/sctp/protocol.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 057479b7bd72..be2fe3ebae78 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -141,7 +141,8 @@ static void sctp_v4_copy_addrlist(struct list_head *addrlist, > struct sctp_sockaddr_entry *addr; > > rcu_read_lock(); > - if ((in_dev = __in_dev_get_rcu(dev)) == NULL) { > + in_dev = __in_dev_get_rcu(dev); > + if (!in_dev) { > rcu_read_unlock(); > return; > } > Acked-by: Vlad Yasevich -vlad