Re: [PATCH v1 06/10] ASoC: dt-bindings: add wsa881x-i2c binding for analog mode

Krzysztof Kozlowski
2024-11-01T08:00:28Z

On Fri, Nov 01, 2024 at 08:57:26AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 01, 2024 at 05:31:50AM +0000, Alexey Klimov wrote:
> > Add binding document for WSA881X family of smart speaker amplifiers
> > that set to work in analog mode only and configurable via i2c only.
> > Such devices are found in Qualcomm QRB4210 RB2 boards with
> > SM4250/SM6115 SoCs.
> >
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> > ---
> > .../bindings/sound/qcom,wsa881x-i2c.yaml | 103 ++++++++++++++++++
> > 1 file changed, 103 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/sound/qcom,wsa881x-i2c.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa881x-i2c.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa881x-i2c.yaml
> > new file mode 100644
> > index 000000000000..51b040b134d2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/qcom,wsa881x-i2c.yaml
>
> Filename must match compatible.

Wait, there is already binding for this device: qcom,wsa881x.yaml. This
has to be there, it's the same device, exactly the same.

Best regards,
Krzysztof