Re: [PATCH v6 4/5] arm64: dts: qcom: sc7280: Add support for camss

Krzysztof Kozlowski
2024-11-27T18:38:40Z

On 27/11/2024 19:32, Krzysztof Kozlowski wrote:
> On 27/11/2024 11:04, Vikram Sharma wrote:
>> Add changes to support the camera subsystem on the SC7280.
>>
>> Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com>
>> Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@quicinc.com>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 170 +++++++++++++++++++++++++++
>> 1 file changed, 170 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 55db1c83ef55..9376755ac43e 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -4426,6 +4426,176 @@ cci1_i2c1: i2c-bus@1 {
>> };
>> };
>>
>> + camss: camss@acaf000 {
>> + compatible = "qcom,sc7280-camss";
>> +
>> + reg = <0x0 0x0acb3000 0x0 0x1000>,
>
> You received feedback to really start testing your code with tools.
> Nothing improved. Do you have troubles running tools or something in
> feedback was not clear? If first - ask. If second - respond to our
> comments, so we can clarify.
>
> Repeating the same mistake over and over and asking us to point you the
> same issue is waste of our time. Sorry, that's not acceptable to me.
>
> NAK.

I saw now previous threads where multiple times I asked the same, e.g.
following coding style. Only at v6 you started doing it.

About the tools, let's recap - we expect absolutely 0 warnings for:
1. `make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

2. standard kernel tools for static analysis, like coccinelle, smatch
and sparse, and fix reported warnings. Also please check for warnings
when building with W=1. Most of these commands (checks or W=1 build) can
build specific targets, like some directory, to narrow the scope to only
your code. The code here looks like it needs a fix. Feel free to get in
touch if the warning is not clear.

(so 4 tools/checks above)

3. clang with W=1

Best regards,
Krzysztof