From: Vikram Mulukutla <markivx@codeaurora.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Srivatsa Vaddagiri <vatsa@codeaurora.org>,
Steve Muckle <steve.muckle@linaro.org>,
Olav Haugan <ohaugan@codeaurora.org>,
Syed Rameez Mustafa <rameezmustafa@codeaurora.org>,
Joonwoo Park <joonwoop@codeaurora.org>,
Pavankumar Kondeti <pkondeti@codeaurora.org>,
Saravana Kannan <skannan@codeaurora.org>,
Bryan Huntsman <bryanh@codeaurora.org>,
Juri Lelli <juri.lelli@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Chris Redpath <chris.redpath@arm.com>,
Robin Randhawa <robin.randhawa@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Todd Kjos <tkjos@google.com>,
Srinath Sridharan <srinathsr@google.com>,
Andres Oportus <andresoportus@google.com>,
Leo Yan <leo.yan@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Vikram Mulukutla <markivx@codeauorora.org>
Subject: Re: [RFC PATCH 0/3] sched: Introduce Window Assisted Load Tracking
Date: Mon, 31 Oct 2016 08:07:46 -0700 [thread overview]
Message-ID: <44f202093ea289c45a5a2710a2787831@codeaurora.org> (raw)
In-Reply-To: <20161028084945.GX3102@twins.programming.kicks-ass.net>
On 2016-10-28 01:49, Peter Zijlstra wrote:
> On Fri, Oct 28, 2016 at 12:57:05AM -0700, Vikram Mulukutla wrote:
>> On 2016-10-28 00:49, Peter Zijlstra wrote:
>> >On Fri, Oct 28, 2016 at 12:10:39AM -0700, Vikram Mulukutla wrote:
>> >>This RFC patch has been tested on live X86 machines with the following
>> >>sanity
>> >>and benchmark results (thanks to Juri Lelli, Dietmar Eggeman, Patrick
>> >>Bellasi
>> >>for initial code reviews):
>> >>
>> >>(Tested on an Intel i7 2nd generation CPU, 8GB RAM, Nvidia GTX950Ti
>> >>graphics,
>> >>with the same frequency list as above. Running Ubuntu 16.04 on a v4.8.2
>> >>baseline. WALT window size was 10ms. Only deltas above 3% are considered
>> >>non-noise.Power measured with Intel RAPL counters)
>> >
>> >Was this comparison done using the use_walt_metric sysctl knob?
>>
>> Yes, it was. You will want to see numbers against a pure 4.8.2 without
>> any
>> of the WALT code, correct?
>
> Yep, because with the sysctl we still run all the accounting code. So
> esp things like the hackbench run are meaningless (note that even the
> CONFIG thing doesn't take out everything).
>
> Also, I think it makes sense to always (also) compare against the
> "performance" governor. That way you can see the drop in absolute
> performance etc..
Ok, here are some numbers. I should be able to get the rest during the
week.
The averages are pretty close, so I figured I would include some
percentile
numbers. PELT and WALT numbers are with schedutil. On average it seems
we're
introducing about 0.5% overhead with the current additional accounting.
Test: perf bench sched messaging -g 50 -l 5000
+-------------+-------------+----------+----------+-----------+
| 4.8.2-walt | Performance | Ondemand | PELT | WALT(10ms)|
+-------------+-------------+----------+----------+---------- +
| | | | | |
| 90th | 17.077 | 17.088 | 17.088 | 17.159 |
| | | | | |
| 96th | 17.117 | 17.421 | 17.198 | 17.343 |
| | | | | |
| Average | 16.910 | 16.916 | 16.937 | 16.962 |
| | | | | |
+-------------+-------------+----------+----------+-----------+
| 4.8.2-raw | Performance | Ondemand | PELT | WALT(10ms)|
+-------------+-------------+----------+----------+-----------+
| | | | | |
| 90th | 16.919 | 17.1694 | 16.986 | 0 |
| | | | | |
| 96th | 16.980 | 17.364 | 17.052 | 0 |
| | | | | |
| Average | 16.841 | 16.902 | 16.860 | 0 |
+-------------+-------------+----------+----------+-----------+
prev parent reply other threads:[~2016-10-31 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 7:10 [RFC PATCH 0/3] sched: Introduce Window Assisted Load Tracking Vikram Mulukutla
2016-10-28 7:10 ` [RFC PATCH 1/3] sched: Introduce structures necessary for WALT Vikram Mulukutla
2016-10-28 7:10 ` [RFC PATCH 2/3] sched: Introduce Window-Assisted CPU utilization Tracking Vikram Mulukutla
2016-10-28 7:38 ` Peter Zijlstra
2016-10-28 7:43 ` Peter Zijlstra
2016-10-28 7:58 ` Vikram Mulukutla
2016-10-28 7:46 ` Peter Zijlstra
2016-10-28 8:03 ` Vikram Mulukutla
2016-10-28 7:52 ` Peter Zijlstra
2016-10-28 7:10 ` [RFC PATCH 3/3] sched: Introduce WALT hooks into core and scheduling classes Vikram Mulukutla
2016-10-28 7:57 ` Peter Zijlstra
2016-10-28 7:29 ` [RFC PATCH 0/3] sched: Introduce Window Assisted Load Tracking Peter Zijlstra
2016-10-28 7:55 ` Vikram Mulukutla
2016-10-28 9:23 ` Peter Zijlstra
2016-10-28 7:49 ` Peter Zijlstra
2016-10-28 7:57 ` Vikram Mulukutla
2016-10-28 8:49 ` Peter Zijlstra
2016-10-31 15:07 ` Vikram Mulukutla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44f202093ea289c45a5a2710a2787831@codeaurora.org \
--to=markivx@codeaurora.org \
--cc=andresoportus@google.com \
--cc=bryanh@codeaurora.org \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=joonwoop@codeaurora.org \
--cc=juri.lelli@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeauorora.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=ohaugan@codeaurora.org \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=rameezmustafa@codeaurora.org \
--cc=robin.randhawa@arm.com \
--cc=skannan@codeaurora.org \
--cc=srinathsr@google.com \
--cc=steve.muckle@linaro.org \
--cc=tkjos@google.com \
--cc=vatsa@codeaurora.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox