From: James Bottomley <jejb@linux.ibm.com>
To: "Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>
Cc: Jonathan Corbet <corbet@lwn.net>,
Federico Vaga <federico.vaga@vaga.pv.it>,
Alex Shi <alexs@kernel.org>, Yanteng Si <siyanteng@loongson.cn>,
Hu Haowen <src.res@email.cn>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc-tw-discuss@lists.sourceforge.net,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 14/15] scsi: ncr53c8xx: replace CCB_MAGIC with bool busy
Date: Fri, 04 Nov 2022 15:57:20 -0400 [thread overview]
Message-ID: <44fa41b4d69219b89e805d572df486c4dda77f08.camel@linux.ibm.com> (raw)
In-Reply-To: <27cefe163e602f7d5b35ba2e966dccf9109798f9.1667330271.git.nabijaczleweli@nabijaczleweli.xyz>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On Wed, 2022-11-02 at 00:06 +0100, Ahelenia Ziemiańska wrote:
[...]
> @@ -4356,7 +4347,7 @@ static int ncr_queue_command (struct ncb *np,
> struct scsi_cmnd *cmd)
> */
>
> /* activate this job. */
> - cp->magic = CCB_MAGIC;
> + cp->busy = true;
>
> /*
> ** insert next CCBs into start queue.
Are you sure this is just an internal magic number? The way these old
scripts engines used to work is that the CCB array forms a mailbox and
the card continually scans the mailbox to see if it has any work to do.
These magic values are often a signal to the card that the CCB array
contains a valid entry it hasn't seen and it should work on it, so the
card might be expecting to see this full 32 bit value.
Regards,
James
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-11-04 19:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 23:04 [PATCH v2 00/15] magic-number.rst funeral rites Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 01/15] hamradio: baycom: remove BAYCOM_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 02/15] hamradio: yam: remove YAM_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 03/15] pcmcia: synclink_cs: remove MGSLPC_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 05/15] coda: remove CODA_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 06/15] Documentation: remove PG_MAGIC (not a magic number) Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 07/15] MIPS: IP27: clean out sn/nmi.h Ahelenia Ziemiańska
2022-11-04 14:50 ` Thomas Bogendoerfer
2022-11-08 15:38 ` наб
2022-11-08 16:41 ` Thomas Bogendoerfer
2022-11-01 23:05 ` [PATCH v2 08/15] MIPS: IP27: remove KV_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 09/15] x86/APM: remove APM_BIOS_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 10/15] scsi: acorn: remove QUEUE_MAGIC_{FREE,USED} Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 11/15] hdlcdrv: remove HDLCDRV_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 12/15] drivers: net: slip: remove SLIP_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 13/15] fcntl: remove FASYNC_MAGIC Ahelenia Ziemiańska
2022-11-01 23:06 ` [PATCH v2 14/15] scsi: ncr53c8xx: replace CCB_MAGIC with bool busy Ahelenia Ziemiańska
2022-11-04 19:57 ` James Bottomley [this message]
2022-11-09 19:40 ` Ahelenia Ziemiańska
2022-11-01 23:06 ` [PATCH v2 15/15] Documentation: remove magic-number.rst Ahelenia Ziemiańska
2022-11-04 18:35 ` [PATCH v2 00/15] magic-number.rst funeral rites Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44fa41b4d69219b89e805d572df486c4dda77f08.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=alexs@kernel.org \
--cc=corbet@lwn.net \
--cc=federico.vaga@vaga.pv.it \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-doc-tw-discuss@lists.sourceforge.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=siyanteng@loongson.cn \
--cc=src.res@email.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox