From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Andrew Donnellan <ajd@linux.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alastair D'Silva <alastair@d-silva.org>
Cc: linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org,
Wei Yongjun <weiyongjun1@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ocxl: Fix return value check in afu_ioctl()
Date: Mon, 6 May 2019 23:54:05 +1000 (AEST) [thread overview]
Message-ID: <44yPNY0bjTz9s7T@ozlabs.org> (raw)
In-Reply-To: <20190504070430.57008-1-weiyongjun1@huawei.com>
On Sat, 2019-05-04 at 07:04:30 UTC, Wei Yongjun wrote:
> In case of error, the function eventfd_ctx_fdget() returns ERR_PTR() and
> never returns NULL. The NULL test in the return value check should be
> replaced with IS_ERR().
>
> This issue was detected by using the Coccinelle software.
>
> Fixes: 060146614643 ("ocxl: move event_fd handling to frontend")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Acked-by: Alastair D'Silva <alastair@d-silva.org>
> Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6be6a8de1b55e719e3f9589491074371
cheers
prev parent reply other threads:[~2019-05-06 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 7:04 [PATCH -next] ocxl: Fix return value check in afu_ioctl() Wei Yongjun
2019-05-05 4:46 ` Alastair D'Silva
2019-05-05 14:22 ` Andrew Donnellan
2019-05-06 13:54 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44yPNY0bjTz9s7T@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=ajd@linux.ibm.com \
--cc=alastair@d-silva.org \
--cc=arnd@arndb.de \
--cc=fbarrat@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox