From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51DCBC4167B for ; Tue, 27 Dec 2022 11:15:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229979AbiL0LPC (ORCPT ); Tue, 27 Dec 2022 06:15:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229762AbiL0LOy (ORCPT ); Tue, 27 Dec 2022 06:14:54 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 306C9D95 for ; Tue, 27 Dec 2022 03:14:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672139645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bZYacPdkOeKkUF+8E+NKgm04sBXoJCSeU32YMBjx4M8=; b=Ze0qZwM1Lq/M6k09LoJhiZ5EBIia47BxSESAKw0vpQcbNdP6Lc0TXSRFQ6Zadq6j870+pY EvhH/npTn8heoPaXhmJiekrS3a1OW3tB0iXYpmCM6zVOJoHZP1mVnD1mXfxb+jEvgIvEjh FceysIksUt/FG1pf09b7QeqapjwB3Ng= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-661-4FqwPLpVNIilLTl-pWqEyA-1; Tue, 27 Dec 2022 06:14:02 -0500 X-MC-Unique: 4FqwPLpVNIilLTl-pWqEyA-1 Received: by mail-ed1-f69.google.com with SMTP id x13-20020a05640226cd00b0047ac11c9774so9087732edd.17 for ; Tue, 27 Dec 2022 03:14:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bZYacPdkOeKkUF+8E+NKgm04sBXoJCSeU32YMBjx4M8=; b=OC0mXzXh2KN71H0izO3xHbYNTXhrJSLm5o2NVDbk9lvMoD2fLo/Yo3FWIsdo6PO5X5 3XZ2tXeT44lUeKsQylge9nEUFV+LRTZYVA9Cl48eJ2c7VJ+rKWTnJJK9Eqqz5E3yUbDs /Z465/AyKR+OhCpQ5nnIDUpH3y8JBUBxv9C5csGJ3lKU1eH31LNtFlBIuguqNrSrHGby VnSNS11usWiEdeEWddxFYnIdN7I3UFcs/brhmJKPxc/exZ9DTkooGR7K0FjthbxdQ+uu jcoGGB0o09QdhJ/NXSc0VYXIcBBClO3wBuXwIoIkBIoN0nRNZzl9LV0LftJ6EC1Ig7mz KhjA== X-Gm-Message-State: AFqh2kqq7bRQoHTQLZ+Gml+3XtGIiiNRsND1WRK0Ac1VWzRAekPmF8cd UgwiULz/Uhew1+M221gdQq0BpjjZrnm/9dJlZJlW05/uXtG+DhjkLQYIFV2OLy/2B98wGZwiImK /7ml0D6CnUu1saWaTiVqM3eNB X-Received: by 2002:a17:906:684b:b0:7c1:ff4:d0c6 with SMTP id a11-20020a170906684b00b007c10ff4d0c6mr18861911ejs.36.1672139641736; Tue, 27 Dec 2022 03:14:01 -0800 (PST) X-Google-Smtp-Source: AMrXdXuTvHu5LyN039mR0jxQHt/DogLpF/rlAQJnHb2v8rN4ygI+wL79VyNiKL5Cu3d62r3keQzLZA== X-Received: by 2002:a17:906:684b:b0:7c1:ff4:d0c6 with SMTP id a11-20020a170906684b00b007c10ff4d0c6mr18861894ejs.36.1672139641325; Tue, 27 Dec 2022 03:14:01 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id 18-20020a170906301200b007bf5250b515sm5889017ejz.29.2022.12.27.03.14.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 03:14:00 -0800 (PST) Message-ID: <4500b24d-8ac0-c7a8-dd8d-bbb660752c71@redhat.com> Date: Tue, 27 Dec 2022 12:14:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2] KVM: use unified srcu interface function Content-Language: en-US To: Hao Peng Cc: kvm@vger.kernel.org, Sean Christopherson , linux-kernel@vger.kernel.org References: From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/25/22 13:48, Hao Peng wrote: > From: Peng Hao > > kvm->irq_routing is protected by kvm->irq_srcu. > > Signed-off-by: Peng Hao Please use the same email to send your message from, for the author, and for the Signed-off-by. Perhaps you can do git config user.name "Peng Hao (Tencent)" git config user.email flyingpenghao@gmail.com ? This is a common set up for people that do not use the company email to write to mailing lists. Paolo > --- > virt/kvm/irqchip.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c > index 1e567d1f6d3d..d3ccfe922880 100644 > --- a/virt/kvm/irqchip.c > +++ b/virt/kvm/irqchip.c > @@ -18,6 +18,10 @@ > #include > #include > > +#define kvm_get_irq_routing(kvm) \ > + srcu_dereference_check((kvm)->irq_routing, &(kvm)->irq_srcu, \ > + lockdep_is_held(&(kvm)->irq_lock)) > + > int kvm_irq_map_gsi(struct kvm *kvm, > struct kvm_kernel_irq_routing_entry *entries, int gsi) > { > @@ -25,8 +29,7 @@ int kvm_irq_map_gsi(struct kvm *kvm, > struct kvm_kernel_irq_routing_entry *e; > int n = 0; > > - irq_rt = srcu_dereference_check(kvm->irq_routing, &kvm->irq_srcu, > - lockdep_is_held(&kvm->irq_lock)); > + irq_rt = kvm_get_irq_routing(kvm); > if (irq_rt && gsi < irq_rt->nr_rt_entries) { > hlist_for_each_entry(e, &irq_rt->map[gsi], link) { > entries[n] = *e; > @@ -216,7 +219,7 @@ int kvm_set_irq_routing(struct kvm *kvm, > } > > mutex_lock(&kvm->irq_lock); > - old = rcu_dereference_protected(kvm->irq_routing, 1); > + old = kvm_get_irq_routing(kvm); > rcu_assign_pointer(kvm->irq_routing, new); > kvm_irq_routing_update(kvm); > kvm_arch_irq_routing_update(kvm); > -- > 2.27.0