public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@mvista.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH -rt] use SA_NODELAY for XScale PMU interrupts
Date: Fri, 08 Sep 2006 12:22:38 -0700	[thread overview]
Message-ID: <4501C2FE.40109@mvista.com> (raw)

In the XScale oprofile support, the performance monitoring unit (PMU)
triggers interrupts and the ISR reads out the performance data.  These
ISRs are currently set to SA_INTERRUPT.  In order to get accurate
performance and profiling data under PREEMPT_RT, these should use
SA_NODELAY.  The functions called by this ISR are limited to
drivers/oprofile functions.

Patch against 2.6.18-rt8

Signed-off-by: Kevin Hilman <khilman@mvista.com>

Index: dev/arch/arm/oprofile/op_model_xscale.c
===================================================================
--- dev.orig/arch/arm/oprofile/op_model_xscale.c
+++ dev/arch/arm/oprofile/op_model_xscale.c
@@ -14,12 +14,14 @@
  * @author Zwane Mwaikambo
  */

-/* #define DEBUG */
+#define DEBUG
 #include <linux/types.h>
 #include <linux/errno.h>
 #include <linux/sched.h>
 #include <linux/oprofile.h>
 #include <linux/interrupt.h>
+#include <linux/irq.h>
+
 #include <asm/irq.h>
 #include <asm/system.h>

@@ -383,8 +385,9 @@ static int xscale_pmu_start(void)
 {
 	int ret;
 	u32 pmnc = read_pmnc();
+	int irq_flags = SA_INTERRUPT | SA_NODELAY;

-	ret = request_irq(XSCALE_PMU_IRQ, xscale_pmu_interrupt, SA_INTERRUPT,
+	ret = request_irq(XSCALE_PMU_IRQ, xscale_pmu_interrupt, irq_flags,
 			"XScale PMU", (void *)results);

 	if (ret < 0) {

             reply	other threads:[~2006-09-08 19:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-08 19:22 Kevin Hilman [this message]
2006-09-08 19:46 ` [PATCH -rt] use SA_NODELAY for XScale PMU interrupts Kevin Hilman
2006-09-08 21:27 ` Arjan van de Ven
2006-09-08 22:48   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4501C2FE.40109@mvista.com \
    --to=khilman@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox