* [PATCH -rt] use SA_NODELAY for XScale PMU interrupts
@ 2006-09-08 19:22 Kevin Hilman
2006-09-08 19:46 ` Kevin Hilman
2006-09-08 21:27 ` Arjan van de Ven
0 siblings, 2 replies; 4+ messages in thread
From: Kevin Hilman @ 2006-09-08 19:22 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner; +Cc: linux-kernel
In the XScale oprofile support, the performance monitoring unit (PMU)
triggers interrupts and the ISR reads out the performance data. These
ISRs are currently set to SA_INTERRUPT. In order to get accurate
performance and profiling data under PREEMPT_RT, these should use
SA_NODELAY. The functions called by this ISR are limited to
drivers/oprofile functions.
Patch against 2.6.18-rt8
Signed-off-by: Kevin Hilman <khilman@mvista.com>
Index: dev/arch/arm/oprofile/op_model_xscale.c
===================================================================
--- dev.orig/arch/arm/oprofile/op_model_xscale.c
+++ dev/arch/arm/oprofile/op_model_xscale.c
@@ -14,12 +14,14 @@
* @author Zwane Mwaikambo
*/
-/* #define DEBUG */
+#define DEBUG
#include <linux/types.h>
#include <linux/errno.h>
#include <linux/sched.h>
#include <linux/oprofile.h>
#include <linux/interrupt.h>
+#include <linux/irq.h>
+
#include <asm/irq.h>
#include <asm/system.h>
@@ -383,8 +385,9 @@ static int xscale_pmu_start(void)
{
int ret;
u32 pmnc = read_pmnc();
+ int irq_flags = SA_INTERRUPT | SA_NODELAY;
- ret = request_irq(XSCALE_PMU_IRQ, xscale_pmu_interrupt, SA_INTERRUPT,
+ ret = request_irq(XSCALE_PMU_IRQ, xscale_pmu_interrupt, irq_flags,
"XScale PMU", (void *)results);
if (ret < 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -rt] use SA_NODELAY for XScale PMU interrupts
2006-09-08 19:22 [PATCH -rt] use SA_NODELAY for XScale PMU interrupts Kevin Hilman
@ 2006-09-08 19:46 ` Kevin Hilman
2006-09-08 21:27 ` Arjan van de Ven
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2006-09-08 19:46 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner; +Cc: linux-kernel
Kevin Hilman wrote:
> In the XScale oprofile support, the performance monitoring unit (PMU)
> triggers interrupts and the ISR reads out the performance data. These
> ISRs are currently set to SA_INTERRUPT. In order to get accurate
> performance and profiling data under PREEMPT_RT, these should use
> SA_NODELAY. The functions called by this ISR are limited to
> drivers/oprofile functions.
>
> Patch against 2.6.18-rt8
>
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
Resend, without the #define DEBUG.
Index: dev/arch/arm/oprofile/op_model_xscale.c
===================================================================
--- dev.orig/arch/arm/oprofile/op_model_xscale.c
+++ dev/arch/arm/oprofile/op_model_xscale.c
@@ -20,6 +20,8 @@
#include <linux/sched.h>
#include <linux/oprofile.h>
#include <linux/interrupt.h>
+#include <linux/irq.h>
+
#include <asm/irq.h>
#include <asm/system.h>
@@ -383,8 +385,9 @@ static int xscale_pmu_start(void)
{
int ret;
u32 pmnc = read_pmnc();
+ int irq_flags = SA_INTERRUPT | SA_NODELAY;
- ret = request_irq(XSCALE_PMU_IRQ, xscale_pmu_interrupt, SA_INTERRUPT,
+ ret = request_irq(XSCALE_PMU_IRQ, xscale_pmu_interrupt, irq_flags,
"XScale PMU", (void *)results);
if (ret < 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -rt] use SA_NODELAY for XScale PMU interrupts
2006-09-08 19:22 [PATCH -rt] use SA_NODELAY for XScale PMU interrupts Kevin Hilman
2006-09-08 19:46 ` Kevin Hilman
@ 2006-09-08 21:27 ` Arjan van de Ven
2006-09-08 22:48 ` Kevin Hilman
1 sibling, 1 reply; 4+ messages in thread
From: Arjan van de Ven @ 2006-09-08 21:27 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Ingo Molnar, Thomas Gleixner, linux-kernel
On Fri, 2006-09-08 at 12:22 -0700, Kevin Hilman wrote:
> In the XScale oprofile support, the performance monitoring unit (PMU)
> triggers interrupts and the ISR reads out the performance data. These
> ISRs are currently set to SA_INTERRUPT. In order to get accurate
> performance and profiling data under PREEMPT_RT, these should use
> SA_NODELAY. The functions called by this ISR are limited to
> drivers/oprofile functions.
>
> Patch against 2.6.18-rt8
hmm I thought the SA_ flags were deprecated ???
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -rt] use SA_NODELAY for XScale PMU interrupts
2006-09-08 21:27 ` Arjan van de Ven
@ 2006-09-08 22:48 ` Kevin Hilman
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2006-09-08 22:48 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: Ingo Molnar, Thomas Gleixner, linux-kernel
Arjan van de Ven wrote:
> On Fri, 2006-09-08 at 12:22 -0700, Kevin Hilman wrote:
>> In the XScale oprofile support, the performance monitoring unit (PMU)
>> triggers interrupts and the ISR reads out the performance data. These
>> ISRs are currently set to SA_INTERRUPT. In order to get accurate
>> performance and profiling data under PREEMPT_RT, these should use
>> SA_NODELAY. The functions called by this ISR are limited to
>> drivers/oprofile functions.
>>
>> Patch against 2.6.18-rt8
>
> hmm I thought the SA_ flags were deprecated ???
>
Sorry, although I said 2.6.18-rt8, the patch is against 2.6.17-rt8,
where the SA_ flags are still used.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-09-08 22:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-08 19:22 [PATCH -rt] use SA_NODELAY for XScale PMU interrupts Kevin Hilman
2006-09-08 19:46 ` Kevin Hilman
2006-09-08 21:27 ` Arjan van de Ven
2006-09-08 22:48 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox