public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Brice Goglin <brice@myri.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Brandon Philips <brandon@ifup.org>,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	Robert Love <rml@novell.com>
Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s
Date: Sat, 09 Sep 2006 01:47:55 -0400	[thread overview]
Message-ID: <4502558B.1010103@myri.com> (raw)
In-Reply-To: <20060908222141.564e3b2a.akpm@osdl.org>

Andrew Morton wrote:
> On Fri, 08 Sep 2006 21:27:46 -0600
> ebiederm@xmission.com (Eric W. Biederman) wrote:
>   
>> Andrew Morton <akpm@osdl.org> writes:
>>     
>>> On Fri, 8 Sep 2006 14:43:00 -0500
>>> Brandon Philips <brandon@ifup.org> wrote:
>>>       
>>>> With CONFIG_PCI_MSI disabled the system boots.  
>>>>         
>>> OK, thanks.
>>>
>>> So likely candidates are:
>>>
>>> - Brice's MSI changes
>>>
>>> - The conversion of i386 to use the genirq code
>>>
>>> - Eric's MSI/genirq changes
>>>
>>> or a combination of the above.  Or something else.
>>>
>>> <adds ccs, steps back expectantly>
>>>       
>> Thanks for the heads up.
>>
>> There was another panic reported last -mm tree I believe as well.
>>     
>
> Yes, there were a couple such reports.  The MSI patches in Greg's tree were
> blamed and rc6-mm1 has a revamped version.  Whether they were sufficiently
> revamped we do not know.
>   


The revamped version is much simpler than the previous ones. We are
basically back to the early ones we had in 2.6.17-mm5, with a tiny
modification to fix the oops that was reported there.

AFAIK, the possible problems that my patches might generate should only be:
* an obvious bug in the code leading to an oops during pci_enable_msi()
or pci_enable_msix() ;
* a wrong detection of whether MSI are supported or not, leading to MSI
being disabled while supported (should not be bad for most drivers), or
enabled while unsupported by the root chipset (would be bad).

Do we have Brandon lspci so that I can see if any of the MSI quirks is
involved?

Brice


  reply	other threads:[~2006-09-09  5:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-08 17:44 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s Brandon Philips
2006-09-08 19:13 ` Andrew Morton
2006-09-08 19:43   ` Brandon Philips
2006-09-08 19:50     ` Andrew Morton
2006-09-09  2:22       ` Benoit Boissinot
2006-09-09  3:27       ` Eric W. Biederman
2006-09-09  5:21         ` Andrew Morton
2006-09-09  5:47           ` Brice Goglin [this message]
2006-09-09  6:01             ` Brandon Philips
2006-09-09  6:14               ` Brice Goglin
2006-09-11  2:14       ` Brandon Philips
2006-09-11 16:51         ` Andrew Morton
2006-09-11 17:55           ` Eric W. Biederman
2006-09-12  6:20           ` Eric W. Biederman
2006-09-12  7:50             ` [patch] genirq/MSI: restore __do_IRQ() compat logic temporarily Ingo Molnar
2006-09-12 12:44               ` Brandon Philips
2006-09-12 14:37               ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4502558B.1010103@myri.com \
    --to=brice@myri.com \
    --cc=akpm@osdl.org \
    --cc=brandon@ifup.org \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rml@novell.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox