From: Andy Whitcroft <apw@shadowen.org>
To: Bob Picco <bob.picco@hp.com>
Cc: akpm@osdl.org, mel@csn.ul.ie, tony.luck@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ia64 specific for Sizing zones and holes in an architecture independent
Date: Sun, 10 Sep 2006 02:03:09 +0100 [thread overview]
Message-ID: <4503644D.9070307@shadowen.org> (raw)
In-Reply-To: <20060829101247.GF10680@localhost>
Bob Picco wrote:
> Andrew,
>
> Mel's latest V9 regressed slightly for ia64 FLATMEM+VIRTUAL_MEM_MAP. When
> the largest hole is greater than LARGE_GAP, vmem_map is allocated before
> free_area_init_nodes; resultant crash follows. Rather than complicate
> alloc_node_mem_map just for this ia64 case, add an adjustment to node_mem_map
> which is later negated by alloc_node_mem_map.
>
> Previous to V9, the mem_map adjustment was done in the scope where allocation
> is achieved in alloc_node_mem_map. The current code is more appropriate but
> unfortunately caused an issue for ia64.
>
> Please add this to the next -mm.
>
> thanks,
>
> bob
>
> Acked-by: Mel Gorman <mel@csn.ul.ie>
> Signed-off-by: Bob Picco <bob.picco@hp.com>
>
> arch/ia64/mm/contig.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.18-rc4-mm3/arch/ia64/mm/contig.c
> ===================================================================
> --- linux-2.6.18-rc4-mm3.orig/arch/ia64/mm/contig.c 2006-08-28 13:10:00.000000000 -0400
> +++ linux-2.6.18-rc4-mm3/arch/ia64/mm/contig.c 2006-08-28 18:18:54.000000000 -0400
> @@ -252,7 +252,12 @@ paging_init (void)
> vmem_map = (struct page *) vmalloc_end;
> efi_memmap_walk(create_mem_map_page_table, NULL);
>
> - NODE_DATA(0)->node_mem_map = vmem_map;
> + /*
> + * alloc_node_mem_map makes an adjustment for mem_map
> + * which isn't compatible with vmem_map.
> + */
Bob, which adjustment is this that is incompatible? Is it the one in
the final stanza, the FLATMEM mem_map instantiation? This one?
#ifdef CONFIG_ARCH_POPULATES_NODE_MAP
if (page_to_pfn(mem_map) != pgdat->node_start_pfn)
mem_map -= pgdat->node_start_pfn;
#endif /* CONFIG_ARCH_POPULATES_NODE_MAP */
-apw
> + NODE_DATA(0)->node_mem_map = vmem_map +
> + find_min_pfn_with_active_regions();
> free_area_init_nodes(max_zone_pfns);
>
> printk("Virtual mem_map starts at 0x%p\n", mem_map);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2006-09-10 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 10:12 [PATCH] ia64 specific for Sizing zones and holes in an architecture independent Bob Picco
2006-09-10 1:03 ` Andy Whitcroft [this message]
2006-09-10 17:10 ` Bob Picco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4503644D.9070307@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=bob.picco@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox