Re: 2.6.18-rc6-mm1

Andrew Morton
2006-09-08T18:04:23Z

On Fri, 08 Sep 2006 19:43:19 +0200
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:

> Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc6/2.6.18-rc6-mm1/
> ...
> > +nommu-move-the-fallback-arch_vma_name-to-a-sensible-place.patch
> ...
>
> I get
>
> kernel/signal.c:2742: warning: weak declaration of
> 'arch_vma_name' after first use results in unspecified behavior
>
> on X86_32, gcc 3.4.1-4mdk.
>
> nommu-move-the-fallback-arch_vma_name-to-a-sensible-place.patch moves
> arch_vma_name() into kernel/signal.c, near its end.
>
> vdso-improve-print_fatal_signals-support-by-adding-memory-maps.patch
> inserts a call to arch_vma_name() into kernel/signal.c, in the first
> half of signal.c.

Thanks. Does this fix it?

--- a/include/linux/mm.h~nommu-move-the-fallback-arch_vma_name-to-a-sensible-place-fix
+++ a/include/linux/mm.h
@@ -1266,7 +1266,7 @@ void drop_slab(void);
extern int randomize_va_space;
#endif

-const char *arch_vma_name(struct vm_area_struct *vma);
+__attribute__((weak)) const char *arch_vma_name(struct vm_area_struct *vma);

#endif /* __KERNEL__ */
#endif /* _LINUX_MM_H */
_