Re: 2.6.18-rc6-mm1 - x86_64-mm-lockdep-dont-force-framepointer.patch

Andi Kleen
2006-09-09T14:45:02Z

On Friday 08 September 2006 14:23, Heiko Carstens wrote:
> x86_64-mm-lockdep-dont-force-framepointer.patch does this:
> > Don't force frame pointers for lockdep
> >
> > Now that stacktrace supports dwarf2 don't force frame pointers for
> > lockdep anymore
> >
> > Cc: mingo@elte.hu
> > Signed-off-by: Andi Kleen <ak@suse.de>
> >
> > ---
> > lib/Kconfig.debug | 1 -
> > 1 files changed, 1 deletion(-)
> >
> > Index: linux/lib/Kconfig.debug
> > ===================================================================
> > --- linux.orig/lib/Kconfig.debug
> > +++ linux/lib/Kconfig.debug
> > @@ -218,7 +218,6 @@ config LOCKDEP
> > bool
> > depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT &&
> > STACKTRACE_SUPPORT && LOCKDEP_SUPPORT select STACKTRACE
> > - select FRAME_POINTER
>
> This patch affects all architecture. I'd like to keep the "select
> FRAME_POINTER" for s390, since we don't support dwarf2.

Perhaps you should port the unwinder then? I know you use it
in userland.

> So this patch should be dropped.

I changed it now to add a if !X86 so it should be ok now

-Andi