public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, torvalds@osdl.org, sergio@sergiomb.no-ip.org,
	jeff@garzik.org, greg@kroah.com, cw@f00f.org,
	bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org,
	harmon@ksu.edu, len.brown@intel.com, vsu@altlinux.ru,
	liste@jordet.net
Subject: Re: [PATCH V3] VIA IRQ quirk behaviour change
Date: Sun, 10 Sep 2006 12:01:53 -0400	[thread overview]
Message-ID: <450436F1.8070203@gentoo.org> (raw)
In-Reply-To: <1157848272.6877.108.camel@localhost.localdomain>

Alan, sorry but I'm still having trouble understanding which aspect of 
my patch you are objecting to. I think I probably misinterpreted one of 
your earlier comments.

My patch included this comment:

> There is still a downside to this patch: if the user inserts a VIA
> PCI card into a VIA-based motherboard, in some circumstances the
> quirk will also run on
> the VIA PCI card. This corner case is hard to avoid.

To which you replied:

> NAK
> 
> This is not a "corner case"
> 
> Very large numbers of VIA mainboards ship with some of the VIA devices
> built in and some of them on the PCI bus. In fact they generally start
> shipped on the board as PCI devices and migrate over time.

and later followed up with:

> If they are on the V-Bus then the IRQ number controls routing if they
> are on the PCI bus the IRQ line controls routing as normal.

The scenario you are talking about there (internal devices on PCI bus vs 
V-bus) is different from the one I was talking about (external VIA-based 
PCI cards going into PCI slots on a VIA-based motherboard).

Regardless of that I tried to piece together what I thought you might be 
trying to say, in order to understand the NAK:

> OK, so per your last mail, most VIA devices start on the PCI bus and
> then later are migrated onto the V-bus.
> 
> Devices on the PCI bus need to be quirked (in some circumstances), as
> when they are on the PCI bus they use the IRQ line for routing, and
> the IRQ line is what the quirk actually modifies.
> 
> V-bus devices do not need the quirk because IRQ routing there is
> handled by IRQ number alone.
> 
> Is the above correct?

And then you replied:

> I've no idea. 

Can you clarify?

Thanks.
Daniel

  parent reply	other threads:[~2006-09-10 16:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-07 22:33 [PATCH V3] VIA IRQ quirk behaviour change Daniel Drake
2006-09-09 14:20 ` Alan Cox
2006-09-09 14:44   ` Daniel Drake
2006-09-09 16:03     ` Alan Cox
2006-09-09 21:34       ` Daniel Drake
2006-09-10  0:31         ` Alan Cox
2006-09-10  0:21           ` Greg KH
2006-09-10  0:39             ` Chris Wedgwood
2006-09-10  4:37               ` Greg KH
2006-09-10  9:48                 ` Stian Jordet
2006-09-10 15:48             ` Daniel Drake
2006-09-10 18:40             ` Lee Revell
2006-09-10 20:45               ` Matthew Garrett
2006-09-10 21:30                 ` Lee Revell
2006-09-10 21:34                   ` Matthew Garrett
2006-09-19 20:04                 ` Lee Revell
2006-09-19 20:12                   ` Matthew Garrett
2006-09-19 20:28                     ` Lee Revell
2006-09-10 16:01           ` Daniel Drake [this message]
2006-09-10 16:39             ` Alan Cox
2006-09-10 16:44               ` Jeff Garzik
2006-09-10 19:06               ` Daniel Drake
2006-09-10 19:41                 ` Alan Cox
2006-09-10 19:21                   ` Stian Jordet
2006-09-11 15:33                     ` Sergio Monteiro Basto
2006-09-11 20:16                       ` Stian Jordet
2006-09-11 21:23                         ` Sergio Monteiro Basto
2006-09-11 21:38                           ` Stian Jordet
2006-09-12 12:37                             ` Sergio Monteiro Basto
2006-09-12 21:38                               ` Stian Jordet
2006-09-13  0:48                                 ` Sergio Monteiro Basto
2006-09-11 21:54                         ` Daniel Drake
2006-09-12  6:21                           ` Stian Jordet
2006-09-11 21:44                       ` Daniel Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450436F1.8070203@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bjorn.helgaas@hp.com \
    --cc=cw@f00f.org \
    --cc=greg@kroah.com \
    --cc=harmon@ksu.edu \
    --cc=jeff@garzik.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liste@jordet.net \
    --cc=sergio@sergiomb.no-ip.org \
    --cc=torvalds@osdl.org \
    --cc=vsu@altlinux.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox