From: Greg Ungerer <gerg@snapgear.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: m68knommu: dma_{alloc,free}_coherent compile error
Date: Mon, 11 Sep 2006 16:02:41 +1000 [thread overview]
Message-ID: <4504FC01.5000805@snapgear.com> (raw)
In-Reply-To: <20060905181716.GG9173@stusta.de>
Hi Adrian,
Adrian Bunk wrote:
> I'm getting the following compile error trying to compile 2.6.18-rc5-mm1
> (but it doesn't seem to be specific to -mm) for m68knommu with
> CONFIG_PCI=n (with -Werror-implicit-function-declaration):
>
> <-- snip -->
>
> ...
> CC drivers/base/dmapool.o
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/drivers/base/dmapool.c: In function 'pool_alloc_page':
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/drivers/base/dmapool.c:170: error: implicit declaration of function 'dma_alloc_coherent'
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/drivers/base/dmapool.c:173: warning: assignment makes pointer from integer without a cast
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/drivers/base/dmapool.c: In function 'pool_free_page':
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/drivers/base/dmapool.c:208: error: implicit declaration of function 'dma_free_coherent'
> make[3]: *** [drivers/base/dmapool.o] Error 1
>
> <-- snip -->
This should fix it?
--- linux-2.6.17/include/asm-m68knommu/dma-mapping.h 2006-06-18
11:49:35.000000000 +1000
+++ linux-2.6.17-uc1/include/asm-m68knommu/dma-mapping.h
2006-09-11 15:51:04.000000000 +1000
@@ -1,10 +1,10 @@
#ifndef _M68KNOMMU_DMA_MAPPING_H
#define _M68KNOMMU_DMA_MAPPING_H
-#include <linux/config.h>
-
#ifdef CONFIG_PCI
#include <asm-generic/dma-mapping.h>
+#else
+#include <asm-generic/dma-mapping-broken.h>
#endif
#endif /* _M68KNOMMU_DMA_MAPPING_H */
--
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com
SnapGear -- a Secure Computing Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
prev parent reply other threads:[~2006-09-11 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-05 18:17 m68knommu: dma_{alloc,free}_coherent compile error Adrian Bunk
2006-09-11 6:02 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4504FC01.5000805@snapgear.com \
--to=gerg@snapgear.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox