From: "Jan Beulich" <jbeulich@novell.com>
To: "Andi Kleen" <ak@suse.de>
Cc: "Michael Matz" <matz@suse.de>,
"Richard Guenther" <rguenther@suse.de>,
<linux-kernel@vger.kernel.org>
Subject: Re: [development-gcc] Re: do_exit stuck
Date: Tue, 12 Sep 2006 07:57:33 +0100 [thread overview]
Message-ID: <4506767D.76E4.0078.0@novell.com> (raw)
In-Reply-To: <200609112217.16811.ak@suse.de>
>Isn't a Kconfig patch missing? I don't see any place that defines
>CONFIG_AS_CFI_SIGNAL_FRAME. Actually Kconfig wouldn't
>be very good for this, so auto testing would be preferable
>(like the cfi test is doing)
Using that framework was the intention (you used a CONFIG_
prefix there, and so did I), but as I wasn't sure about its status,
and as I also was doing this against plain 2.6.18-rc6, I didn't add
the actual detection logic. Actually I also think that should be
done a little differently to allow for better future extension, i.e.
instead of adding to CFLAGS store the auto-detected results in
a header and forcibly -include it.
>BTW the tree you generated it against doesn't seem to match the latest
>tree. I had to fix some rejects.
I didn't create it against your quilt tree, that's true.
>Also it would be nice if you could give a full description that could
>be used as a commit message.
Below.
>Other than that it looks good.
>
>Ok maybe a one liner comment on why UNW_DEFAULT_RA does this magic.
In order to deal with gcc's somewhat broken handling of noreturn
functions (the call instruction in which may be immediately followed
by a subsequent function, thus leading to the call's return address
pointing into that [wrong] function), add heuristics to the unwinder
to distinguish standard call frames from syscall, exception, or
interruption ones. Also provide for utilizing newer gas'
.cfi_signal_frame for non-heuristic based detection, pending
addition of the respective assembler feature detection logic.
Jan
next prev parent reply other threads:[~2006-09-12 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200608291332.18499.ak@suse.de>
[not found] ` <Pine.LNX.4.64.0608301626150.6582@wotan.suse.de>
[not found] ` <44F5CAD0.76E4.0078.0@novell.com>
[not found] ` <200608301740.41729.ak@suse.de>
2006-09-11 15:37 ` [development-gcc] Re: do_exit stuck Jan Beulich
2006-09-11 20:17 ` Andi Kleen
2006-09-12 6:57 ` Jan Beulich [this message]
2006-09-12 6:32 ` Andi Kleen
2006-09-12 8:35 ` Jakub Jelinek
2006-09-12 8:45 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4506767D.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matz@suse.de \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox