Re: [PATCH v1 2/3] bus: mhi: core: Introduce debugfs entries for MHI

bbhatt
2020-09-18T17:09:52Z

On 2020-09-17 16:36, Randy Dunlap wrote:
> On 9/17/20 3:19 PM, Bhaumik Bhatt wrote:
>> diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig
>> index a8bd9bd..ae68347 100644
>> --- a/drivers/bus/mhi/Kconfig
>> +++ b/drivers/bus/mhi/Kconfig
>> @@ -12,3 +12,11 @@ config MHI_BUS
>> communication protocol used by the host processors to control
>> and communicate with modem devices over a high speed peripheral
>> bus or shared memory.
>> +
>> +config MHI_BUS_DEBUG
>> + bool "Debugfs support for the MHI bus"
>> + depends on MHI_BUS && DEBUG_FS
>> + help
>> + Enable debugfs support for use with the MHI transport. Allows
>> + reading and/or modifying some values within the MHI controller
>> + for debug and test purposes.
>
> from Documentation/process/coding-style.rst:
>
> """For all of the Kconfig* configuration files throughout the source
> tree,
> the indentation is somewhat different. Lines under a ``config``
> definition
> are indented with one tab, while help text is indented an additional
> two
> spaces."""
>
> Several lines above use spaces instead of one tab...
Thank you for pointing out. I will fix this.