Re: [PATCH v2 4/4] crypto: rockchip/crypto - add DT bindings documentation

Heiko Stuebner
2015-11-06T09:00:53Z

Am Freitag, 6. November 2015, 09:17:24 schrieb Zain Wang:
> Add DT bindings documentation for the rk3288 crypto drivers.
>
> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
> ---
>
> Changde in v2:
> - None
>
> Changed in v1:
> - remove the _crypto suffix
> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
> - remove the description of status
>
> .../devicetree/bindings/crypto/rockchip-crypto.txt | 29
++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip-
crypto.txt
>
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
b/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> new file mode 100644
> index 0000000..d27e203
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> @@ -0,0 +1,29 @@
> +Rockchip Electronics And Security Accelerator
> +
> +Required properties:
> +- compatible: Should be "rockchip,rk3288-crypto"
> +- reg: base physical address of the engine and length of memory mapped
> + region
> +- interrupts: interrupt number
> +- clocks: reference to the clocks about crypto
> +- clock-names: "aclk" used to clock data
> + "hclk" used to clock data
> + "srst" used to clock crypto accelerator

mistmatch between description and example. I think you mean "sclk" instead of
"srst", like we talked about in the first version.

> + "apb_pclk" used to clock dma
> +
> +Examples:
> +
> + crypto: cypto-controller@ff8a0000 {
> + compatible = "rockchip,rk3288-crypto";
> + reg = <0xff8a0000 0x4000>;
> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_CRYPTO>,
> + <&cru HCLK_CRYPTO>,
> + <&cru SCLK_CRYPTO>,
> + <&cru ACLK_DMAC1>;
> + clock-names = "aclk",
> + "hclk",
> + "sclk",
> + "apb_pclk";
> + status = "okay";
> + };
>