Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108

Martin Bligh
2006-09-14T22:46:23Z

> i disagree. Consider the following example from LTT:
...
> trace_socket_sendmsg(sock, sock->sk->sk_family,
> sock->sk->sk_type,
> sock->sk->sk_protocol,
> size);
...

> what do the 5 extra lines introduced by trace_socket_sendmsg() tell us?
> Nothing. They mostly just duplicate the information i already have from
> the function declaration. They obscure the clear view of the function:
...
> the resulting visual and structural redundancy hurts.

Couldn't that be easily fixed by just doing

trace_socket_sendmsg(sock, size);

and have it work out which esoteric parts of the sock we want to trace,
and which we don't? Is much less visually invasive, and gives the same
effect.

M.