[patch 30/37] Remove redundant up() in stop_machine()

Greg KH
2006-09-06T23:05:55Z

[-- Attachment #1: remove-redundant-up-in-stop_machine.patch --]
[-- Type: text/plain, Size: 751 bytes --]

-stable review patch. If anyone has any objections, please let us know.

------------------
From: "Yingchao Zhou" <yingchao.zhou@gmail.com>

An up() is called in kernel/stop_machine.c on failure, and also in the
caller (unconditionally).

Signed-off-by: Zhou Yingchao <yingchao.zhou@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
kernel/stop_machine.c | 1 -
1 file changed, 1 deletion(-)

--- linux-2.6.17.11.orig/kernel/stop_machine.c
+++ linux-2.6.17.11/kernel/stop_machine.c
@@ -111,7 +111,6 @@ static int stop_machine(void)
/* If some failed, kill them all. */
if (ret < 0) {
stopmachine_set_state(STOPMACHINE_EXIT);
- up(&stopmachine_mutex);
return ret;
}

--