From: Jiri Slaby <jirislaby@gmail.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mxser: PCI refcounts
Date: Sat, 16 Sep 2006 14:57:54 +0159 [thread overview]
Message-ID: <450BF4E9.2040407@gmail.com> (raw)
In-Reply-To: <450BF0A1.4040807@gmail.com>
Jiri Slaby wrote:
> Alan Cox wrote:
>> Switch to pci ref counts for mxser when handling PCI devices. Use
>> pci_get_device and drop the reference when we finish and unload.
>
> Please, don't do that. These all drivers need to be rewritten to pci
> probing (for this one I have a patch, but I waited for confirmation of
> previous patchset, but nothing has come, so perhaps I will clone it as
> NEW/EXPERIMENTAL 1.9.1-with-pci-probing-driver) and when pci_find_device
> is there, we can `grep -r` it to know, which drivers need that. The same
Just a note. I tried to do all this work, but it was nacked:
http://www.fi.muni.cz/~xslaby/unpr/linux_patches/pci_find/
You can pick up from there some patches for non-device drivers (such as buses or
so), if you want to not do the work yourself again...
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
next prev parent reply other threads:[~2006-09-16 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 14:12 [PATCH] mxser: PCI refcounts Alan Cox
2006-09-16 12:40 ` Jiri Slaby
2006-09-16 12:58 ` Jiri Slaby [this message]
2006-09-16 17:02 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450BF4E9.2040407@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox