[PATCH 1/11] LTTng-core 0.5.111 : Relay+DebugFS (DebugFS fix)

[PATCH 1/11] LTTng-core 0.5.111 : Relay+DebugFS (DebugFS fix)

[Mathieu Desnoyers]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

1 - DebugFS stalled dentry patch
DebugFS seems to keep a stalled dentry when a process is in a directory that is
being removed. Force a differed deletion.
patch-2.6.17-lttng-core-0.5.111-debugfs.diff


OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 

[-- Attachment #2: patch-2.6.17-lttng-core-0.5.111-debugfs.diff --]
[-- Type: text/plain, Size: 644 bytes --]

--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -266,6 +266,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_dir);
 void debugfs_remove(struct dentry *dentry)
 {
 	struct dentry *parent;
+	int ret = 0;
 	
 	if (!dentry)
 		return;
@@ -278,9 +279,10 @@ void debugfs_remove(struct dentry *dentr
 	if (debugfs_positive(dentry)) {
 		if (dentry->d_inode) {
 			if (S_ISDIR(dentry->d_inode->i_mode))
-				simple_rmdir(parent->d_inode, dentry);
+				ret = simple_rmdir(parent->d_inode, dentry);
 			else
-				simple_unlink(parent->d_inode, dentry);
+				ret = simple_unlink(parent->d_inode, dentry);
+			if(ret) d_delete(dentry);
 		dput(dentry);
 		}
 	}

Re: [PATCH 1/11] LTTng-core 0.5.111 : Relay+DebugFS (DebugFS fix)

[Greg KH]

On Sat, Sep 16, 2006 at 03:51:03AM -0400, Mathieu Desnoyers wrote:
> 1 - DebugFS stalled dentry patch
> DebugFS seems to keep a stalled dentry when a process is in a directory that is
> being removed. Force a differed deletion.
> patch-2.6.17-lttng-core-0.5.111-debugfs.diff
> 
> 
> OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
> Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 

> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -266,6 +266,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_dir);
>  void debugfs_remove(struct dentry *dentry)
>  {
>  	struct dentry *parent;
> +	int ret = 0;
>  	
>  	if (!dentry)
>  		return;
> @@ -278,9 +279,10 @@ void debugfs_remove(struct dentry *dentr
>  	if (debugfs_positive(dentry)) {
>  		if (dentry->d_inode) {
>  			if (S_ISDIR(dentry->d_inode->i_mode))
> -				simple_rmdir(parent->d_inode, dentry);
> +				ret = simple_rmdir(parent->d_inode, dentry);
>  			else
> -				simple_unlink(parent->d_inode, dentry);
> +				ret = simple_unlink(parent->d_inode, dentry);
> +			if(ret) d_delete(dentry);

Are you saying that perhaps all other users of simple_unlink() are also
broken like this?  If so, why not just fix simple_unlink()?

Also, wrong coding style used :(

thanks,

greg k-h

Re: [PATCH 1/11] LTTng-core 0.5.111 : Relay+DebugFS (DebugFS fix)

[Karim Yaghmour]

Mathieu Desnoyers wrote:
> 1 - DebugFS stalled dentry patch

I think it would be best if patches posted were in the body of
the email instead of as attachments. It makes it easier to
review and comment.

Thanks,

Karim
-- 
President  / Opersys Inc.
Embedded Linux Training and Expertise
www.opersys.com  /  1.866.677.4546

Re: [PATCH 1/11] LTTng-core 0.5.111 : Relay+DebugFS (DebugFS fix)

[Christoph Hellwig]

On Sun, Sep 17, 2006 at 09:21:15PM -0400, Karim Yaghmour wrote:
> 
> Mathieu Desnoyers wrote:
> > 1 - DebugFS stalled dentry patch
> 
> I think it would be best if patches posted were in the body of
> the email instead of as attachments. It makes it easier to
> review and comment.

Also the subject line is utterly useless.  Please take a look at
Documentation/SubmittingPatches for the general format of a patch.
> 
> Thanks,
> 
> Karim
> -- 
> President  / Opersys Inc.
> Embedded Linux Training and Expertise
> www.opersys.com  /  1.866.677.4546
---end quoted text---

Re: [PATCH 1/11] LTTng-core 0.5.111 : Relay+DebugFS (DebugFS fix)

[Mathieu Desnoyers]

* Greg KH (gregkh@suse.de) wrote:
> On Sat, Sep 16, 2006 at 03:51:03AM -0400, Mathieu Desnoyers wrote:
> > 1 - DebugFS stalled dentry patch
> > DebugFS seems to keep a stalled dentry when a process is in a directory that is
> > being removed. Force a differed deletion.
> > patch-2.6.17-lttng-core-0.5.111-debugfs.diff
> > 
> > 
> > OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
> > Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 
> 
> > --- a/fs/debugfs/inode.c
> > +++ b/fs/debugfs/inode.c
> > @@ -266,6 +266,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_dir);
> >  void debugfs_remove(struct dentry *dentry)
> >  {
> >  	struct dentry *parent;
> > +	int ret = 0;
> >  	
> >  	if (!dentry)
> >  		return;
> > @@ -278,9 +279,10 @@ void debugfs_remove(struct dentry *dentr
> >  	if (debugfs_positive(dentry)) {
> >  		if (dentry->d_inode) {
> >  			if (S_ISDIR(dentry->d_inode->i_mode))
> > -				simple_rmdir(parent->d_inode, dentry);
> > +				ret = simple_rmdir(parent->d_inode, dentry);
> >  			else
> > -				simple_unlink(parent->d_inode, dentry);
> > +				ret = simple_unlink(parent->d_inode, dentry);
> > +			if(ret) d_delete(dentry);
> 
> Are you saying that perhaps all other users of simple_unlink() are also
> broken like this?  If so, why not just fix simple_unlink()?
> 

I don't think that libfs is fundamentally broken, as simple_unlink always
returns 0 but simple_rmdir may fail if !simple_empty(dentry). I think that the
decision of what to do in such situation is "simply" left to the caller.

But you probably know more than I do on that matter.

Mathieu



OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68