public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Eugeny S. Mints" <eugeny.mints@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: pm list <linux-pm@lists.osdl.org>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [linux-pm] [RFC] CPUFreq PowerOP integration, Centrino PM Core and OPs registration 2/3
Date: Mon, 18 Sep 2006 15:16:59 +0400	[thread overview]
Message-ID: <450E802B.800@gmail.com> (raw)
In-Reply-To: <20060918104624.GB4973@elf.ucw.cz>

Pavel Machek wrote:
> Hi!
> 
>> +/* 
>> + * FIXME: very temporary implementation, just to prove the concept !! 
>> + */
>> +static int 
>> +process_pwr_param(struct pm_core_point *opt, int op, char *param_name,
>> +		  int va_arg)
> 
> Ok, so can we get final implementation? Parsing strings in drivers is
> evil...
ok, i saw this your comment when you mentioned it for the first time and I 
explicitly put it in TODO letter sent along with the patchset.

Can you instead of such implementation details try to review and give us your 
comments if any on interfaces approach and namely on cpufreq/PowerOP integration 
at cpufreq_driver layer; comments _based_ on the code. The issue with string 
parsing does not affect cpufreq/PowerOP integration interfaces since currently I 
keep going with parameter names(strings) interface for PowerOP Core regardless 
of whether parsing will eventually occur - at PM Core or POwerOP Core.

	Eugeny
> 
> 									Pavel
> 


  reply	other threads:[~2006-09-18 11:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 14:50 [RFC] CPUFreq PowerOP integration, Centrino PM Core and OPs registration 2/3 Eugeny S. Mints
2006-09-18 10:46 ` [linux-pm] " Pavel Machek
2006-09-18 11:16   ` Eugeny S. Mints [this message]
2006-10-07  3:19 ` Dominik Brodowski
2006-10-09 13:42   ` Eugeny S. Mints

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450E802B.800@gmail.com \
    --to=eugeny.mints@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox