From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933611AbcIFUTM (ORCPT ); Tue, 6 Sep 2016 16:19:12 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:52873 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755955AbcIFUTJ (ORCPT ); Tue, 6 Sep 2016 16:19:09 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Russell King - ARM Linux , Eric Miao , Haojian Zhuang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mmp: replace NO_IRQ Date: Tue, 06 Sep 2016 22:19:18 +0200 Message-ID: <4510913.a46LvNLeqZ@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160906194443.GC1041@n2100.armlinux.org.uk> References: <20160906140808.2883875-1-arnd@arndb.de> <6239709.hYdxF7WW9G@wuerfel> <20160906194443.GC1041@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:4FSaO6/kNNa2kjztm+tAZkXfku8CuUBCF6eD+J8vQnZcd7Lb6gj A72jrqrFfUCmYyVx+03DzqCFrf8/Zv1zfDzNbOQhsyU3f4GHA8Va9JCjcwXdKpXkJSReV9x zpsgBnAJOxihnLr73AZrf+0AyezMJk+W9FkjwPDC1yTge922tn6mkuPipGhbNYjYfUeq+9A qMtXa8DQDTC0zzl5KD0Jg== X-UI-Out-Filterresults: notjunk:1;V01:K0:5Uwo49YftyY=:+BvfrRKP89XkOfV3+ggADi 7hAKaoJ3Zg0ZnOWNrFfS8p1P58FqqRXU56a08RqaMax9iIZMOjaHeIb/kxXhnUxda+nQCV68s XExdskxZjqumrJHDrPLgh3TkJAkVoYvdFjX+WZIOimo9ujiLq4ejLTW4FHBT7jwyRHaBqMLZp e3pG84FKCkpunLEpt3az772nFsipaj3F+h7wA+6Xu1Z5qk5zFmiBeK33axfMMGHFP5KDPsB1P 6HaWZ0C46QAe+dLSOxQfMqaXeRPRJoS6Y4v71ZnajJMB6hFGmW4gNlVKT8lp/+GcZTSY3Y6tj 6R+cPHg5qfizaPUD8autpd6WoWjZo9GNtsrUIDQCBkO66G6d43EkMocecyvQPd9PmJ9c12j21 WlBTn1uqZZmLgMRDOktTMMIGZLm851o/C8hZUV7C6kmgPFGbRHmbxtLcF9oh6ZYxvhqiILD6L QR1Vca2qwr4M6ADOR44mV1a1HnxbQawxiRW+sFMFzocugdi883+3O5Vw2fUZ3/mhnoq6k4Y2L +ZBi7ZHsJmZ+znYwBoZur/i93Zsbo7YCpSVwZ6J3TU4044yFGFjQBfs+xNJNO9rkeHyNk9tTG 31lXOuibS0qJH7Wylrzz1Gh5VDGyFGbJXTdycCBHSlfzj5cRzPBb2fZMX/XuYa8q62VljwLht FNeSuObXsJ2INBvHrjujdeFo11EhePz9pNn5vzXHX9xks5esf6yTVf6TKI0lnN4Xyn5kQmV78 bpvnjNOmewlz9waD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 6, 2016 8:44:43 PM CEST Russell King - ARM Linux wrote: > On Tue, Sep 06, 2016 at 09:28:17PM +0200, Arnd Bergmann wrote: > > On Tuesday, September 6, 2016 3:24:42 PM CEST Russell King - ARM Linux wrote: > > > On Tue, Sep 06, 2016 at 04:07:56PM +0200, Arnd Bergmann wrote: > > I'm experimenting with cleaning up the file some more, but it's unclear > > if doing it another way is an actual improvement, or if a larger change > > is worth the risk for regressions, given how little interest there is > > in this platform in general. > > If there's little interest in it, and little stomach to fix it, maybe > the better thing is to remove it if no one has an interest in it? > > > [1] https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2016-September/003803.html > > What Linus has failed to understand is that the reason why we've kept > NO_IRQ as -1 is that changing NO_IRQ to 0 results in regressions - I've > been through as much as the code that I'm personally happy to convert > each time this has come up, and what remains has been the stuff that > I've not been happy to touch through fear of breaking it. Out of the 20 patches os so that I did for the complete removal on ARM, a clear majority was fixing code that is already broken (usually in error handling code paths that are never exercised in practice though). > So, changing NO_IRQ to 0 results in regressions. Trying to fix the > sites probably results in regressions too (I've already seen one > example with your UCB1x00 patch of such breakage caused by mindless > "conversion".) The patch was correct, the only problem that you pointed out already was that it needs to be applied on top of your patch. I didn't check when the file was touched the last time but only looked at the current state in linux-next that happened to be from your patch last week. Arnd