From: James Bruce <bruce@andrew.cmu.edu>
To: Dmitry Torokhov <dtor@insightbb.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>
Subject: Re: 2.6.19 -mm merge plans (input patches)
Date: Thu, 21 Sep 2006 03:53:45 -0400 [thread overview]
Message-ID: <45124509.1050205@andrew.cmu.edu> (raw)
In-Reply-To: <200609202118.27741.dtor@insightbb.com>
Dmitry Torokhov wrote:
> On Wednesday 20 September 2006 17:55, Dave Jones wrote:
>> On Wed, Sep 20, 2006 at 05:29:43PM -0400, Dmitry Torokhov wrote:
>> > On 9/20/06, Andrew Morton <akpm@osdl.org> wrote:
>> > > remove-silly-messages-from-input-layer.patch
>> >
>> > I firmly believe that we should keep reporting these conditions. This
>> > way we can explain why keyboard might be losing keypresses. I am open
>> > to changing the message text. Would "atkbd.c: keyboard reported error
>> > condition (FYI only)" be better?
>>
>> Q: What do you expect users to do when they see the message?
>
> A: Nothing. But when they tell me that sometimes they lose keystrokes I
> can ask them if they see it in dmesg. And if they see it there is nothing
> I can do. Again, if you could suggest a better wording that would not alarm
> unsuspecting users that would be great.
If it is needed only to answer "does my keyboard work", maybe you could
store an error count in the driver, or put it to the event layer.
Coupled with a way to retrieve the value (ioctl+evtest,proc,sys,etc),
the user can get the information they need, but only when they actually
want it.
The networking subsystem seems to store a lot of its error conditions in
proc-accessible counters rather than printing a warning. Thus there is
precedent for avoiding dmesg spam in this way.
Just my $0.02
- Jim Bruce
next prev parent reply other threads:[~2006-09-21 7:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 21:29 2.6.19 -mm merge plans (input patches) Dmitry Torokhov
2006-09-20 21:50 ` Andrew Morton
2006-09-21 14:39 ` Stefan Seyfried
2006-09-20 21:55 ` Dave Jones
2006-09-21 1:18 ` Dmitry Torokhov
2006-09-21 7:53 ` James Bruce [this message]
2006-09-21 13:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45124509.1050205@andrew.cmu.edu \
--to=bruce@andrew.cmu.edu \
--cc=akpm@osdl.org \
--cc=dtor@insightbb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox