Re: [patch] mspec driver

Jes Sorensen
2006-09-20T16:45:07Z

Randy.Dunlap wrote:
> On 20 Sep 2006 03:26:53 -0400 Jes Sorensen wrote:
>> @@ -439,6 +439,14 @@ config SGI_MBCS
>> If you have an SGI Altix with an attached SABrick
>> say Y or M here, otherwise say N.
>>
>> +config MSPEC
>> + tristate "Memory special operations driver"
>> + depends on IA64
>> + help
>> + If you have an ia64 and you want to enable memory special
>> + operations support (formerly known as fetchop), say Y here,
>> + otherwise say N.
>
> If the answers are {Y, N}, then it should be bool instead of tristate.
> If tristate, M can be an answer....

True, will look into that.

>> +#include <linux/config.h>
>
> Don't need to include config.h (it's done by build system).
> (well, actually autoconf.h is)

True, I remember that changing - what happens when the code sits around
for too long. Personally I prefer it is included explicitly, but I'll
change it anyway.

>> +static struct vm_operations_struct mspec_vm_ops = {
>> + .open = mspec_open,
>> + .close = mspec_close,
>> + .nopfn = mspec_nopfn
>> +};
>
> These interfaces create a userspace interface, eh?
> So those 3 functions could stand to have kernel-doc function
> comments and have documentation in Documentation/ABI/ (see its
> README file for more details). Maybe check all of
> Documentation/SubmitChecklist for other items...

Mmmmmmm, I'd need someone else to write that up, might take a little
longer to get done. Robin know any volunteers?

>> +/*
>> + * mspec_init
>> + *
>> + * Called at boot time to initialize the mspec facility.
>> + */
>> +static int __init
>> +mspec_init(void)
>
> ugh, matey. All on one line.

Sorry, but I think that one falls under personal preference. It's short
than 80, which is what really matters.

Cheers,
Jes